Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-31] Test Driver/Dependencies/bindings-build-record.swift fails on OS X #42654

Closed
swift-ci opened this issue Dec 4, 2015 · 12 comments
Closed

[SR-31] Test Driver/Dependencies/bindings-build-record.swift fails on OS X #42654

swift-ci opened this issue Dec 4, 2015 · 12 comments
Labels
compiler The Swift compiler in itself test failure test suite Area: test suite

Comments

@swift-ci
Copy link
Collaborator

swift-ci commented Dec 4, 2015

Previous ID SR-31
Radar None
Original Reporter tmandry (JIRA User)
Type Bug
Status Closed
Resolution Done
Environment

OS X 10.11.1
swift commit e0e5257

Other output before failure:

--- Running tests for swift ---
--- check-swift-macosx-x86_64 ---
+ cd /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/stdlib/public/SwiftShims
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E make_directory /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./lib/swift
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E create_symlink /Users/tyler/code/swift/build/Ninja-DebugAssert/llvm-macosx-x86_64/lib/clang/3.8.0 /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./lib/swift/clang
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E make_directory /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./lib/swift/install-tmp/install-tmp
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E remove /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./lib/swift/install-tmp/install-tmp/clang
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E create_symlink ../clang/3.8.0 /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./lib/swift/install-tmp/install-tmp/clang
+ cd /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/test
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E remove_directory /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./swift-test-results/x86_64-apple-macosx10.9
+ /usr/local/Cellar/cmake/3.3.2/bin/cmake -E make_directory /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./swift-test-results/x86_64-apple-macosx10.9
+ /usr/local/bin/python /Users/tyler/code/swift/llvm/utils/lit/lit.py -sv --xunit-xml-output=/Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/./swift-test-results/x86_64-apple-macosx10.9/lit-tests.xml /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64
lit.py: lit.cfg:211: note: using swift: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swift
lit.py: lit.cfg:211: note: using swiftc: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swiftc
lit.py: lit.cfg:211: note: using swift-autolink-extract: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swift-autolink-extract
lit.py: lit.cfg:211: note: using sil-opt: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/sil-opt
lit.py: lit.cfg:211: note: using sil-extract: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/sil-extract
lit.py: lit.cfg:211: note: using lldb-moduleimport-test: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/lldb-moduleimport-test
lit.py: lit.cfg:211: note: using swift-ide-test: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swift-ide-test
lit.py: lit.cfg:211: note: using clang: /Users/tyler/code/swift/build/Ninja-DebugAssert/llvm-macosx-x86_64/bin/clang
lit.py: lit.cfg:211: note: using llvm-link: /Users/tyler/code/swift/build/Ninja-DebugAssert/llvm-macosx-x86_64/bin/llvm-link
lit.py: lit.cfg:211: note: using swift-llvm-opt: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/swift-llvm-opt
lit.py: lit.cfg:255: note: Using resource dir: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/lib/swift
lit.py: lit.cfg:281: note: Using Clang module cache: /var/folders/xl/kvdphsfj6230q3f8_m9h5zhw0000gn/T/swift-testsuite-clang-module-cacheVDw2y1
lit.py: lit.cfg:285: note: Using code completion cache: /var/folders/xl/kvdphsfj6230q3f8_m9h5zhw0000gn/T/swift-testsuite-completion-cacheyh0RpD
lit.py: lit.cfg:535: note: Testing OS X x86_64-apple-macosx10.9
lit.py: lit.cfg:614: note: Running tests on Mac OS X version 10.11.1 (15B42)
lit.py: lit.cfg:759: note: Using platform module dir: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/lib/swift/%target-sdk-name/x86_64
lit.py: lit.cfg:211: note: using sourcekitd-test: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/sourcekitd-test
lit.py: lit.cfg:211: note: using complete-test: /Users/tyler/code/swift/build/Ninja-DebugAssert/swift-macosx-x86_64/bin/complete-test
Additional Detail from JIRA
Votes 3
Component/s
Labels Bug
Assignee tmandry (JIRA)
Priority Medium

md5: b4c33156e31acff4d5ce4cbd74d5feb8

Issue Description:

I consistently get the following test failure when building from master (using
@belkadan
Copy link
Contributor

belkadan commented Dec 8, 2015

Yikes. Is your filesystem customized in any way, or just using the settings OS X installs with?

(There's a longstanding issue with the same test on Linux, which is why it's disabled there right now. That's tracked internally as rdar://problem/21515673.)

@swift-ci
Copy link
Collaborator Author

Comment by Alex Lew (JIRA)

I get the exact same error, and it's my only test failure. I don't believe my filesystem is configured in any special way – what sort of settings would I be looking for?

@norio-nomura
Copy link
Contributor

I guess that is timezone issue.
bindings-build-record.swift creates main~buildrecord.swiftdeps as following:

// RUN: echo '{version: "'$(%swiftc_driver_plain -version | head -n1)'", inputs: {"./main.swift": [443865900, 0], "./other.swift": [443865900, 0], "./yet-another.swift": [443865900, 0]}, build_time: [443865901, 0]}' > %t/main~buildrecord.swiftdeps

llvm::sys::TimeValue(443865900, 0) is 2014/01/24 8:05 UTC that is 2014/01/24 0:05 in PST.
But, on my local file system, main.swift is cloned as 2014/01/24 0:05 in my timezone JST that is 2014/01/23 15:05 in UTC.
It seems Git keeps timestamp as local time.

@norio-nomura
Copy link
Contributor

Oh, bindings-build-record.swift touches them:

// RUN: touch -t 201401240005 %t/*

The test is not timezone portable.

@belkadan
Copy link
Contributor

THANK YOU for this![]( I'm embarrassed to have made this mistake. Will fix)

@ddunbar
Copy link
Member

ddunbar commented Dec 10, 2015

`touch -r` is sometimes useful if you can get some other file with a reference timestamp. llbuild uses this for a couple similar tests.

@belkadan
Copy link
Contributor

Fixed in 24032f9.

@belkadan
Copy link
Contributor

Back to Tyler to verify.

@norio-nomura
Copy link
Contributor

👍

@swift-ci
Copy link
Collaborator Author

Comment by Tyler Mandry (JIRA)

Sorry for the delay. Would be happy to verify, but now I can't build swift: SR-241. I tried on both master and the commit you mentioned.

@swift-ci
Copy link
Collaborator Author

Comment by Tyler Mandry (JIRA)

Okay, this appears to work now. Got:

Testing Time: 703.44s
  Expected Passes    : 2355
  Expected Failures  : 5
  Unsupported Tests  : 34

@belkadan
Copy link
Contributor

Great! Feel free to Close the bug, then.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added test suite Area: test suite test failure compiler The Swift compiler in itself and removed bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. labels Nov 6, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself test failure test suite Area: test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@norio-nomura @ddunbar @belkadan @swift-ci @AnthonyLatsis