Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3107] SwiftPM's dependency on swiftc wasn't sufficient to prevent out-of-date modules in self-host build #5184

Closed
belkadan opened this issue Nov 1, 2016 · 2 comments
Labels

Comments

@belkadan
Copy link

belkadan commented Nov 1, 2016

Previous ID SR-3107
Radar None
Original Reporter @belkadan
Type Bug
Status Closed
Resolution Cannot Reproduce

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 4717bbeccf9d307e494a0b6d6c8cb8c6

Issue Description:

During a pull request that only touched test configuration, SwiftPM failed to pass its self-host build step with

/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/swiftpm/Sources/swift-test/main.swift:11:8: error: module file was created by an older version of the compiler; rebuild 'Commands' and try again: /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/buildbot_linux/swiftpm-linux-x86_64/debug/Commands.swiftmodule

import Commands
       ^

(and several more errors of the same form for Basic and TestSupport)

PR-testing bots are reused frequently, even across branches, so it's not surprising that there were stale products from a previous build. However, I would have expected these to be rebuilt, no problem.

Build log attached.

@ddunbar
Copy link
Member

ddunbar commented Nov 2, 2016

We have two dependencies edges which should prevent this:

  1. We have a general dependency edge on the version of the swift compiler.
  2. We have dependency edges on all .swiftmodules reported to us as dependencies by swiftc.

Somehow that was insufficient here, or we failed to honor them correctly...

@ddunbar
Copy link
Member

ddunbar commented Nov 2, 2016

Unfortunately this is going to be hard to track down w/o being able to reproduce.

The original failure was here:
https://ci.swift.org/job/swift-PR-Linux-smoke-test/2159/
GitHub pull request #5566 of commit 9d40580a5d8a060db5733905b11ee7909e95e686, no merge conflicts.

The previous build of that builder was:
GitHub pull request #5565 of commit 26dc738a911cff516ea037dad3e86d7915718471, no merge conflicts.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants