New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-3275] Lack of command 'git' causes swift-build crash. #5165
Comments
Using the development snapshot of 15 december on Ubuntu 16.04; bouke@ubuntu-imac:~/Developer/HAP$ which git
bouke@ubuntu-imac:~/Developer/HAP$ git
The program 'git' is currently not installed. You can install it by typing:
sudo apt install git
bouke@ubuntu-imac:~/Developer/HAP$ swift build
Fetching https://github.com/Bouke/CLibSodium.git
git clone --bare https://github.com/Bouke/CLibSodium.git /media/sf_Developer/HAP/.build/repositories/CLibSodium.git--9212624310367625262
error: Failed to clone https://github.com/Bouke/CLibSodium.git to <AbsolutePath:"/media/sf_Developer/HAP/.build/repositories/CLibSodium.git--9212624310367625262"> So, no longer a crash, but improved diagnostics would be welcome. |
Hey scoot (JIRA User), I was looking for some relatively self-contained bugs to get into the swiftpm code base. Saw that it no longer crashed and verified with the 3.1 and master branch what it was doing - but wasn't sure what "improved diagnostics" you were thinking about. I thought "If git doesn't exist on the local system, fail out early and report that..." as a first order cut of something useful, but did you have something else in mind? |
Right now we don't report what error actually occurred when we fail to clone, I think fixing that problem will fix this issue. |
Environment
Swift version 3.0 (swift-3.0-RELEASE)
Target: x86_64-unknown-linux-gnu
Additional Detail from JIRA
md5: 695fa998c110daea59a7f5c65a9ca3e6
is duplicated by:
Issue Description:
I noticed following crash when there is no 'git' command in the system.
The text was updated successfully, but these errors were encountered: