Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3414] swift package build doesn't work only swift build #5148

Closed
masters3d opened this issue Dec 14, 2016 · 6 comments
Closed

[SR-3414] swift package build doesn't work only swift build #5148

masters3d opened this issue Dec 14, 2016 · 6 comments
Labels

Comments

@masters3d
Copy link
Contributor

Previous ID SR-3414
Radar None
Original Reporter @masters3d
Type Bug
Status Closed
Resolution Won't Do
Environment

Apple Swift version 3.0.2 (swiftlang-800.0.63 clang-800.0.42.1)
Target: x86_64-apple-macosx10.9

Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 2914080647561559e781518907d48e26

Issue Description:

swift package build
//error: unknown command: build
//enter `/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-package --help' for usage information

Doesn't work. Only ``swift build`` seems to work.

https://github.com/apple/swift-evolution/blob/master/proposals/0085-package-manager-command-name.md

@ankitspd
Copy link
Member

huh I think that line under proposed solution was left over during some revision, check alternatives section where it says:
"This proposal originally suggested swift build and swift package build would be aliases. In order to avoid having multiple ways to run the same command, we updated the proposal to emphasize only swift build."

@abertelrud Should we update the proposal and remove 3rd point under proposed solution?

@masters3d
Copy link
Contributor Author

The Alternative section in this proposal seems to be historical, the git history doesnt show any editing to those sections. The main question was choosing `package` vs `spm`

@abertelrud
Copy link
Contributor

@aciidb0mb3r: IIRC the original plan was that `swift package <verb>` would support all the verbs, and that `swift build` and `swift test` would be shortcuts for `swift package build` and `swift package test`, respectively. In the old command line arg parser that was somewhat cumbersome (since `swift-build` and `swift-test` are really separate executables from `swift-package`), but with the new, modular command line arg parser it should be a lot easier. It seems that the documentation reflected the intent and not the implementation.

I do think that it would be more consistent to have `swift build` and `swift test` just be shortcuts for `swift package build` and `swift package test`, but I know that others feel that it's redundant to do so. We should make a decision and either change the documentation or change the implementation (my own preference is the latter).

@ankitspd
Copy link
Member

Ah I see, I too think we should not make `swift build` and `swift test` a part of `swift package` but we should definitely discuss this and make a decision.

@masters3d
Copy link
Contributor Author

Would changing the approved proposal required a swift evolution review? Sorry about the politics, just curious.

@ankitspd
Copy link
Member

I don't think we should do this since we have specific well known tools now, but we can discuss on swift-build-dev if this is really desirable.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants