Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-342] Convert or add *.sil version of all *.swift tests in test/SILOptimizer and test/IRGen #42964

Open
gottesmm opened this issue Dec 22, 2015 · 2 comments
Open

[SR-342] Convert or add *.sil version of all *.swift tests in test/SILOptimizer and test/IRGen #42964

gottesmm opened this issue Dec 22, 2015 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers nfc Flag: No Functional Change

Comments

@gottesmm
Copy link
Member

Previous ID SR-342
Radar None
Original Reporter @gottesmm
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: c67ceae294f0653e3d62193d939cc2e1

Issue Description:

Due to problems with the SILParser there are tests for the SILOptimizer and IRGen that were written as swift tests instead of *.sil tests.

Using *.swift tests allows for frontend changes to potentially cause a test to no longer test what it is supposed to test due to codegen changes.

This should expose additional bugs in the SILParser yielding further work.
@Dante-Broggi
Copy link
Contributor

Has this been done?

@gottesmm
Copy link
Member Author

gottesmm commented Sep 3, 2018

No, but it may no longer be relevant.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added the nfc Flag: No Functional Change label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers nfc Flag: No Functional Change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gottesmm @AnthonyLatsis @Dante-Broggi