Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3464] Assertion failure in TestURLSession.test_dataTaskWithURL #704

Closed
gparker42 mannequin opened this issue Dec 20, 2016 · 8 comments
Closed

[SR-3464] Assertion failure in TestURLSession.test_dataTaskWithURL #704

gparker42 mannequin opened this issue Dec 20, 2016 · 8 comments

Comments

@gparker42
Copy link
Mannequin

gparker42 mannequin commented Dec 20, 2016

Previous ID SR-3464
Radar None
Original Reporter @gparker42
Type Bug
Status Resolved
Resolution Won't Do
Additional Detail from JIRA
Votes 0
Component/s libdispatch
Labels Bug
Assignee None
Priority Medium

md5: d192f919d7837e82321c544d91555294

Issue Description:

TestURLSession.test_dataTaskWithURL has a failing assertion.

TestFoundation: src/common/knote.c:155: knote_disable: Assertion `!(kn->kev.flags & 0x0008)' failed.

This failure is at least two months old in the swift-ci PR test of swift-corelibs-libdispatch.
https://ci.swift.org/view/All/job/swift-corelibs-libdispatch-PR-Linux/44/

@gparker42
Copy link
Mannequin Author

gparker42 mannequin commented Dec 20, 2016

Test disabled in swift-corelibs-foundation PR#754.

@pushkarnk
Copy link

dgrove-oss (JIRA User) , seabaylea (JIRA User) - I remember the assertion failure reported above was fixed in libkqueue for the URLSession PR. Is the latest libkqueue not being picked up? I am aware of a discussion, on the libdispatch mailing list, around moving away from libkqueue.. but I am unable to join the dots here! Can you please help?

@swift-ci
Copy link

swift-ci commented Jan 3, 2017

Comment by David Grove (JIRA)

The version of libkqueue we are currently using is a bit old (1873b186 from Sept 23, 2016). I don't think we specifically did anything to fix this assertion failure since then however (as far as I know it is an intermittent failure we have been ignoring).

Once the whole dispatch team gets back from vacation (next week) we can discuss whether it makes sense to update the libkqueue version being used by dispatch. But I don't expect a refresh of the libkqueue to resolve this problem.

If you have a deterministic way to trigger this failure, it might be worth investigating further. Does the test trigger this assertion every time? Previous times this assertion have been triggered have not been repeatable.

@gparker42
Copy link
Mannequin Author

gparker42 mannequin commented Jan 3, 2017

IIRC the CI test was failing often or always, but it looks like ci.swift.org was rebooted recently and doesn't have any history for it.

@pushkarnk
Copy link

dgrove-oss (JIRA User) - I believe this PR mheily/libkqueue#10 by ianpartridge (JIRA User) did fix the assertion failure.

@swift-ci
Copy link

swift-ci commented Jan 4, 2017

Comment by David Grove (JIRA)

That pull request is from May; it was merged in June and is included in the version of libkqueue we are currently using.

@pushkarnk
Copy link

I am un-assigning myself from this since this is a libkqueue failure and in my understanding we have plans to move to a kqueue-less, epoll-based libdispatch in the near future.

Changing the component to libdispatch. Thanks.

@swift-ci
Copy link

Comment by David Grove (JIRA)

We've removed libkqueue; issue no longer relevant.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants