Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-3467] popen failure #5146

Closed
ankitspd opened this issue Dec 20, 2016 · 4 comments
Closed

[SR-3467] popen failure #5146

ankitspd opened this issue Dec 20, 2016 · 4 comments
Assignees
@abertelrud
Labels
bug

Comments

@ankitspd
Copy link
Member

Previous ID SR-3467
Radar None
Original Reporter @aciidb0mb3r
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee @abertelrud
Priority Medium

md5: 99e1e251b3f56bdc2728c53e975c89a2

relates to:

  • SR-2703 Investigate SwiftPM CI popen failure

Issue Description:

The intermittent linux popen failure reappeared, last time it was due to progress bar tests having pseudo terminals.
https://ci.swift.org/job/swift-llbuild-PR-Linux/46/console

Test Suite 'ProgressBarTests' started at 18:10:11.508
Test Case 'ProgressBarTests.testProgressBar' started at 18:10:11.508
Test Case 'ProgressBarTests.testProgressBar' passed (0.002 seconds).
Test Suite 'ProgressBarTests' passed at 18:10:11.510
Executed 1 test, with 0 failures (0 unexpected) in 0.002 (0.002) seconds
Test Suite 'ShellTests' started at 18:10:11.510
Test Case 'ShellTests.testPopen' started at 18:10:11.510
fatal error: 'try!' expression unexpectedly raised an error: POSIX.ShellError.popen(arguments: ["echo", "foo"], close error: Unknown error -1): file /home/buildnode/disk2/workspace/swift-llbuild-PR-Linux/swift/stdlib/public/core/ErrorType.swift, line 182
Current stack trace:
@abertelrud
Copy link
Contributor

@aciidb0mb3r, do you think that this a different issue, or that the ptty fix in SR-2703 was incomplete?

@abertelrud
Copy link
Contributor

Actually, I think I know what's going on here. The `closeOnDeinit` parameter of `LocalFileOutputByteStream`'s initializer defaults to true, but the calling code in both `ProgressBarTests` and `TerminalControllerTests` still closes the file descriptor too.

@abertelrud
Copy link
Contributor

#887

@abertelrud
Copy link
Contributor

Merged fix onto master in e207e73

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abertelrud abertelrud

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankitspd @abertelrud