Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-3625] Make Process class thread safe #5132

Closed
ankitspd opened this issue Jan 13, 2017 · 4 comments
Closed

[SR-3625] Make Process class thread safe #5132

ankitspd opened this issue Jan 13, 2017 · 4 comments

Comments

@ankitspd
Copy link
Member

Previous ID SR-3625
Radar None
Original Reporter @aciidb0mb3r
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: ac87199636c671e4aea0358ea4c35bc3

Issue Description:

It would be nice if Process class, especially waitUntilExit was thread safe. It will also allow us to clean up ProcessSet API and client will not need to call remove() anymore.
@swift-ci
Copy link
Contributor

Comment by Stephen Brown (JIRA)

Hi first time contributor here and I'm really keen to help out. Is there somewhere else in the project I would be able to base an implementation on or do you have any further advice you would like to add that you think could be useful?

@ankitspd
Copy link
Member Author

We have a couple of thread safe structures right now: ProcessSet, GitRepository, RepositoryManager
Basically it should be safe to call waitUntilExit from different threads.

@ankitspd
Copy link
Member Author

ankitspd commented Feb 7, 2017

#924

@heckj
Copy link
Contributor

heckj commented Feb 28, 2017

should this be closed now that #924 has been merged?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heckj @ankitspd @swift-ci