New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-3698] Ensure dry run works for SourceKit #46283
Comments
Comment by Félix Fischer (JIRA) I can't reproduce this. This is my output of running ./swift/utils/build-script --dry-run
|
The problem is that the 'dry run' flag is ignored by the part of the build that handles source kit, not that any errors are seen. If you look at the full logs you'll find that the 'make' command is run for the foundation libraries even when dry run is specified (which it shouldn't). That's because the dependency for libdispatch is added and built in the script https://github.com/apple/swift/blob/master/tools/SourceKit/CMakeLists.txt#L507-L524 Have a look for 'Generating libdispatch.so' in the logs, and the output surrounding that ... |
Comment by Félix Fischer (JIRA) — If you look at the full logs Which logs do you mean? Also... in the bug description, it says: — Modify this so that dry run does not build the script. I'm confused. Does it build a script? Or were you talking about it building the actual libdispatch binary? Cheers 🙂 |
Additional Detail from JIRA
md5: 24ff9aa4a9de834c434f5fcd1101bacf
Parent-Task:
Issue Description:
The current build script rules for SourceKit do not respect the dry-run flag, owing to the existence of the need to make the libdispatch library. Modify this so that dry run does not build the script.
The text was updated successfully, but these errors were encountered: