New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-3803] Forward SIGINT to swift-build-tool #5120
Comments
Comment by Félix Fischer (JIRA) I don't quite understand what you mean. Do you mean "if utils/build-script recieves a SIGINT, forward it to swift-build-tool"? |
I meant the swift tools in the package manager, i.e. swift build, swift package and swift test. These invoke swift-build-tool as needed, they should forward the SIGINT to swift-build-tool. |
Comment by Artemiy Sobolev (JIRA) Hi, Ankit, it seems to be implemented already by you in SwiftTool's runLLBuild - the build process is added to ProcessSet and in termination handler all processes from ProcessSet are terminated. |
Yeah, I think we can mark it as closed. I think there was concern about this not working but I haven't heard otherwise. |
Comment by Artemiy Sobolev (JIRA) From the timeline perspective it was implemented after the issue was created. Do you think it is worth adding integration tests? |
Additional Detail from JIRA
md5: 767c0943f01a4624e3c1aee52dfa5f38
Issue Description:
We need to track the invocation and forward sigint signal if received.
The text was updated successfully, but these errors were encountered: