Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3803] Forward SIGINT to swift-build-tool #5120

Closed
ankitspd opened this issue Jan 31, 2017 · 5 comments
Closed

[SR-3803] Forward SIGINT to swift-build-tool #5120

ankitspd opened this issue Jan 31, 2017 · 5 comments
Labels

Comments

@ankitspd
Copy link
Member

Previous ID SR-3803
Radar None
Original Reporter @aciidb0mb3r
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 767c0943f01a4624e3c1aee52dfa5f38

Issue Description:

We need to track the invocation and forward sigint signal if received.

@swift-ci
Copy link
Contributor

Comment by Félix Fischer (JIRA)

I don't quite understand what you mean. Do you mean "if utils/build-script recieves a SIGINT, forward it to swift-build-tool"?

@ankitspd
Copy link
Member Author

I meant the swift tools in the package manager, i.e. swift build, swift package and swift test. These invoke swift-build-tool as needed, they should forward the SIGINT to swift-build-tool.

@swift-ci
Copy link
Contributor

Comment by Artemiy Sobolev (JIRA)

Hi, Ankit, it seems to be implemented already by you in SwiftTool's runLLBuild - the build process is added to ProcessSet and in termination handler all processes from ProcessSet are terminated.

@ankitspd
Copy link
Member Author

Yeah, I think we can mark it as closed. I think there was concern about this not working but I haven't heard otherwise.

@swift-ci
Copy link
Contributor

Comment by Artemiy Sobolev (JIRA)

From the timeline perspective it was implemented after the issue was created. Do you think it is worth adding integration tests?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants