Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-3856] FixIt suggests incorrect code for dispatch_async #699

Closed
swift-ci opened this issue Feb 3, 2017 · 4 comments
Closed

[SR-3856] FixIt suggests incorrect code for dispatch_async #699

swift-ci opened this issue Feb 3, 2017 · 4 comments
Assignees
@NachoSoto
Labels
bug libdispatch

Comments

@swift-ci
Copy link

swift-ci commented Feb 3, 2017

Previous ID SR-3856
Radar None
Original Reporter maury.markowitz@gmail.com (JIRA User)
Type Bug
Status Resolved
Resolution Done
Environment

osx 10.12.3 (16D32), Xcode Version 8.2.1 (8C1002)

Additional Detail from JIRA
Votes 0
Component/s libdispatch
Labels Bug
Assignee @NachoSoto
Priority Medium

md5: 93632b41a768e963fa9c8871fd2d9b40

Issue Description:

I had this:
dispatch_async(DispatchQueue.main) {

Fixit replaced it with:

DispatchQueue.main.asynchronously() {

The correct version is:

DispatchQueue.main.asynch() {
@belkadan
Copy link

belkadan commented Feb 3, 2017

Fixed in #6958, although that currently isn't included in Swift 3.1. @NachoSoto, do you want to cherry-pick it there?

@NachoSoto
Copy link

Which branch would I need to cherrypick it to?

@belkadan
Copy link

belkadan commented Feb 3, 2017

swift-3.1-branch, per the Swift 3.1 Release Process.

@NachoSoto
Copy link

apple/swift#7254

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
@AnthonyLatsis AnthonyLatsis mentioned this issue Nov 8, 2023
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NachoSoto NachoSoto

Labels
bug libdispatch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NachoSoto @belkadan @swift-ci