Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3881] URLError missing 2 codes, and has 3 other bad codes #3890

Closed
lilyball mannequin opened this issue Feb 6, 2017 · 3 comments
Closed

[SR-3881] URLError missing 2 codes, and has 3 other bad codes #3890

lilyball mannequin opened this issue Feb 6, 2017 · 3 comments

Comments

@lilyball
Copy link
Mannequin

lilyball mannequin commented Feb 6, 2017

Previous ID SR-3881
Radar None
Original Reporter @lilyball
Type Bug
Status Resolved
Resolution Done
Environment

Apple Swift version 3.0.2 (swiftlang-800.0.63 clang-800.0.42.1)
Apple Swift version 3.1 (swiftlang-802.0.31.3 clang-802.0.30.2)

Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Bug, SDKOverlay
Assignee @lilyball
Priority Medium

md5: eea1f362bef24b9cdd7bc75bc45fa252

Issue Description:

URLError is missing codes for NSURLErrorAppTransportSecurityRequiresSecureConnection and NSURLErrorDataLengthExceedsMaximum.

In addition, the codes .backgroundSessionRequiresSharedContainer, .backgroundSessionInUseByAnotherProcess, and .backgroundSessionWasDisconnected are broken. They're implemented as computed properties instead of enum cases, which means accessing them actually crashes. And the accessors on URLError.Code aren't even public (but they're exposed via the computed properties on URLError).

@lilyball
Copy link
Mannequin Author

lilyball mannequin commented Feb 6, 2017

Since this is a bug, I'm just going to go ahead and fix this even though it's in the SDK overlay.

@lilyball
Copy link
Mannequin Author

lilyball mannequin commented Feb 15, 2017

This was submitted as PR #7282.

@lilyball
Copy link
Mannequin Author

lilyball mannequin commented Feb 20, 2017

Merged in 63b122c.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants