Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-3888] gyb_foundation_support.py incorrectly implements _unconditionallyBridgeFromObjectiveC #3889

Open
phausler opened this issue Feb 7, 2017 · 1 comment
Open

[SR-3888] gyb_foundation_support.py incorrectly implements _unconditionallyBridgeFromObjectiveC #3889

phausler opened this issue Feb 7, 2017 · 1 comment
Labels
bug BuildScript Foundation SDKOverlay

Comments

@phausler
Copy link
Member

phausler commented Feb 7, 2017

Previous ID SR-3888
Radar rdar://problem/30400139
Original Reporter @phausler
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Bug, BuildScript, SDKOverlay
Assignee None
Priority Medium

md5: 91492ff8d5813205e107850de79d3814

Issue Description:

_unconditionallyBridgeFromObjectiveC should construct an empty structural types when the reference NSValue is nil.

gyb_foundation_support.py has the following line:
let unwrappedSource = source!

which defeats the use of _unconditionallyBridgeFromObjectiveC
@belkadan
Copy link

belkadan commented Feb 8, 2017

I'm not sure that really matters. There's no empty structural equivalent of an NSValue, is there?

The "do the empty thing" was put in for cases where nullability was incorrectly annotated. It's not a primary path we're supposed to support, and it's okay for new types to not accept such annotations.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug BuildScript Foundation SDKOverlay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phausler @belkadan