Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-3957] swift-stdlib-tool-substitute will stop working with Xcode 8.3 #46542

Closed
swift-ci opened this issue Feb 14, 2017 · 16 comments
Closed

[SR-3957] swift-stdlib-tool-substitute will stop working with Xcode 8.3 #46542

swift-ci opened this issue Feb 14, 2017 · 16 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-3957
Radar rdar://30491233
Original Reporter dmishe (JIRA User)
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug
Assignee @gparker42
Priority Medium

md5: c1317ed3d53dbd7e882c71c8f60959fc

Issue Description:

Xcode 8.3 beta 2 removed the standalone swift-stdlib-tool binary, in favor of moving the tool into Xcode itself.

That utility is used by this script https://github.com/apple/swift/blob/master/utils/swift-stdlib-tool-substitute, which is a simple wrapper around Xcode version.

In turn, this wrapper is used in a few parts of the build-script, which means that it will stop working when Xcode 8.3 is released.

It seems that swift-stdlib-tool should be open-source and live in the Swift repo.

@belkadan
Copy link
Contributor

I don't think it's meant for general use. But @gparker42 owns this tool, so he can speak to any changes necessary.

@gparker42
Copy link
Mannequin

gparker42 mannequin commented Feb 15, 2017

build-script does not use swift-stdlib-tool. It currently copies swift-stdlib-tool-substitute into place when building an Xcode-compatible toolchain. Xcode no longer needs a swift-stdlib-tool file in the toolchain so swift-stdlib-tool-substitute will soon be deleted.

@swift-ci
Copy link
Collaborator Author

Comment by Dmitry Shevchenko (JIRA)

Ah got it, thanks for explanation. The tool is still really useful for third party build systems to perform runtime libraries copy. It would be nice to keep it around.

@gparker42
Copy link
Mannequin

gparker42 mannequin commented Feb 15, 2017

You should file a bug report against Xcode. This might be a good candidate for an xcodebuild option.

@swift-ci
Copy link
Collaborator Author

Comment by Dmitry Shevchenko (JIRA)

Thanks, radar is attached to this bug.

@modocache
Copy link
Mannequin

modocache mannequin commented Mar 7, 2017

I'm surprised and a little disappointed to hear this tool has been removed; Facebook's Buck build toolchain interfaces with it in https://github.com/facebook/buck/blob/0da788b8facf970968f29ee8025e671186fbdb85/src/com/facebook/buck/apple/AppleCxxPlatforms.java#L488-L524. We rely upon it as a mechanism for packaging the Swift runtime libraries with an Apple bundle. Removing the tool means additional work before Facebook can support building and packaging apps that use Swift.

Is it possible to phase the tool out incrementally? I wasn't expecting it to suddenly be removed.

@modocache
Copy link
Mannequin

modocache mannequin commented Mar 7, 2017

dmishe (JIRA User), could you please publish your Radar on https://openradar.appspot.com/page/1? I'd like to duplicate it.

@modocache
Copy link
Mannequin

modocache mannequin commented Mar 8, 2017

For anyone looking to duplicate the Radar, here it is: https://openradar.appspot.com/radar?id=5608273688395776 🙂

@bob-wilson
Copy link

Thanks for all the feedback on this. We hadn't realized how many people were relying on this tool. We're going to reconsider this and see what we can do to fix this.

Oh, and you can stop filing duplicate radars now!

@modocache
Copy link
Mannequin

modocache mannequin commented Mar 12, 2017

Thanks, @bob-wilson!! I really appreciate the decision to keep it around.

I wrote down some of my thoughts on why I think it's nice to have it as utility outside of Xcode and xcodebuild: http://modocache.io/swift-stdlib-tool. Maybe some of those ideas are off the mark; if you have any feedback, I'd really appreciate that too!

@swift-ci
Copy link
Collaborator Author

swift-ci commented Jun 6, 2017

Comment by Dmitry Shevchenko (JIRA)

@bob-wilson, the latest Xcode beta again removes this tool again. Is that how it's going be from now on?

@gparker42
Copy link
Mannequin

gparker42 mannequin commented Jun 7, 2017

No, it's supposed to be there. We'll take a look.

@gparker42
Copy link
Mannequin

gparker42 mannequin commented Jun 7, 2017

Dmitry, are you using this week's Xcode 9 beta 1 (build 9M136h) ?

@swift-ci
Copy link
Collaborator Author

swift-ci commented Jun 7, 2017

Comment by Dmitry Shevchenko (JIRA)

That's right.

@bob-wilson
Copy link

The issue with Xcode 9 beta 1 was an internal Apple problem, which we are fixing. I'm going to close this again.

@gparker42
Copy link
Mannequin

gparker42 mannequin commented Jun 23, 2017

This is fixed in Xcode 9 beta 2. Thanks for the bug report.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Development

No branches or pull requests

3 participants