Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4031] Compound name for platform condition is accepted #46614

Closed
rintaro mannequin opened this issue Feb 22, 2017 · 2 comments
Closed

[SR-4031] Compound name for platform condition is accepted #46614

rintaro mannequin opened this issue Feb 22, 2017 · 2 comments
Assignees
@rintaro
Labels
accepts invalid Bug: Accepts invalid bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself parser Area → compiler: The legacy C++ parser

Comments

@rintaro
Copy link
Mannequin

rintaro mannequin commented Feb 22, 2017

Previous ID SR-4031
Radar None
Original Reporter @rintaro
Type Bug
Status Resolved
Resolution Done
Environment

Xcode 8.3 beta 2 (8W120l)
Apple Swift version 3.1 (swiftlang-802.0.31.3 clang-802.0.30.2)
Target: x86_64-apple-macosx10.9

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, AcceptsInvalid, Parser
Assignee @rintaro
Priority Medium

md5: 9d7f72be85caf498315116bd4c641fee

Issue Description:

This should be rejected.

#if os(foo:bar:)(macOS)
    print("ok")
#endif

But fixing this would be source breaking change.
@belkadan
Copy link
Contributor

We can definitely fix it in Swift 4 mode, but I still think I'm not so concerned about these cases.

@rintaro
Copy link
Mannequin Author

rintaro mannequin commented May 19, 2017

#7955

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rintaro rintaro

Labels
accepts invalid Bug: Accepts invalid bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself parser Area → compiler: The legacy C++ parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@belkadan