Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-4154] dispatch PR testing failing: libpwq not properly initialized #696

Closed
swift-ci opened this issue Mar 3, 2017 · 1 comment
Closed
Assignees

Comments

@swift-ci
Copy link

swift-ci commented Mar 3, 2017

Previous ID SR-4154
Radar None
Original Reporter dgrove-oss (JIRA User)
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 1
Component/s libdispatch, Project Infrastructure
Labels Bug
Assignee @shahmishal
Priority Medium

Watchers: @shahmishal

md5: 5077a6d2c0cf775e222169bdae94f657

Issue Description:

libdispatch PR tests are failing (for example see: https://ci.swift.org/job/swift-corelibs-libdispatch-PR-Linux/71/ )

I believe the problem is that the libpwq git submodule is not being properly checked out during PR testing (or the wrong version of libpwq is being checked out). Looking at the console log from the last failed PR test, you can see the output from the autoreconf step of the build is:

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: adding subdirectory libpwq to autoreconf
autoreconf: Entering directory `libpwq'
autoreconf: configure.ac: not using Autoconf
autoreconf: Leaving directory `libpwq'

If libpwq was properly checked out, the output would look like this.

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
autoreconf: configure.ac: tracing
autoreconf: configure.ac: adding subdirectory libpwq to autoreconf
autoreconf: Entering directory `libpwq'
autoreconf: running: libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:6: installing './compile'
configure.ac:7: installing './missing'
Makefile.am: installing './depcomp'
autoreconf: Leaving directory `libpwq'

Eventually, the build fails with this problem:

Making distclean in libpwq
make[1]: Entering directory '/home/buildnode/jenkins/workspace/swift-corelibs-libdispatch-PR-Linux/swift-corelibs-libdispatch/libpwq'
make[1]: *** No rule to make target 'distclean'. Stop.
make[1]: Leaving directory '/home/buildnode/jenkins/workspace/swift-corelibs-libdispatch-PR-Linux/swift-corelibs-libdispatch/libpwq'
Makefile:457: recipe for target 'distclean-recursive' failed
make: *** [distclean-recursive] Error 1

This is a symptom of libpwq not being included in the autoreconf correctly. Therefore its Makefile was never generated and the distclean command failed.

@shahmishal
Copy link
Member

Job fixed.

 > git submodule update --init --recursive # timeout=20

https://ci.swift.org/job/swift-corelibs-libdispatch-PR-Linux/72/console

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants