Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-4330] Use reference-counted copy-on-write existential buffers #46913

Closed
bob-wilson opened this issue Mar 24, 2017 · 2 comments
Closed

[SR-4330] Use reference-counted copy-on-write existential buffers #46913

bob-wilson opened this issue Mar 24, 2017 · 2 comments
Assignees
Labels
affects ABI Flag: Affects ABI compiler The Swift compiler in itself improvement

Comments

@bob-wilson
Copy link

Previous ID SR-4330
Radar rdar://problem/22591042
Original Reporter @bob-wilson
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, AffectsABI
Assignee @aschwaighofer
Priority Medium

md5: f4fe9f3489eca1390e7a47d05b48b7a5

Issue Description:

This tracks work to use reference-counted copy-on-write buffers when the payload of an existential does not fit in the inline buffer. This will avoid some malloc() allocation of buffers in exchange for reference counts and uniqueness checks, which we expect to be an overall win for performance.

@milseman
Copy link
Mannequin

milseman mannequin commented Jul 7, 2017

aschwaighofer@apple.com (JIRA User), this was done, correct?

@aschwaighofer
Copy link
Member

This was done for swift 4.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects ABI Flag: Affects ABI compiler The Swift compiler in itself improvement
Projects
None yet
Development

No branches or pull requests

2 participants