Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4357] Running benchmark in release mode #46936

Closed
palimondo mannequin opened this issue Mar 25, 2017 · 5 comments
Closed

[SR-4357] Running benchmark in release mode #46936

palimondo mannequin opened this issue Mar 25, 2017 · 5 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@palimondo
Copy link
Mannequin

palimondo mannequin commented Mar 25, 2017

Previous ID SR-4357
Radar rdar://problem/31298973
Original Reporter @palimondo
Type Bug
Status Closed
Resolution Cannot Reproduce
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug
Assignee None
Priority Medium

md5: d8a9a15cea31ec0c310877d022a12c92

Issue Description:

I’m trying to run the benchmarks for swift-source on my machine.

./swift/utils/build-script --benchmark

works, but takes ages. So I was trying to run the benchmark in release mode:

./swift/utils/build-script -R -B

this fails with the last command being:

/Users/mondo/Developer/swift-source/build/Ninja-ReleaseAssert/swift-macosx-x86_64/bin/Benchmark_Driver run -o O --output-dir /Users/mondo/Developer/swift-source/build/Ninja-ReleaseAssert/swift-macosx-x86_64/benchmark/logs --swift-repo /Users/mondo/Developer/swift-source/swift --iterations
[..].
Benchmark_Driver run: error: argument -i/--iterations: expected one argument

I have tried this to no avail:

./swift/utils/build-script -R --benchmark-num-onone-iterations 3

Is what I’m trying to do not supported by build-script, or am I misunderstanding how to use the benchmark suit?
@swift-ci
Copy link
Collaborator

Comment by Colin Douglas Howell (JIRA)

I'm pretty sure this is in fact a bug in the script, though I haven't tracked it down.

If I remember correctly, if you look closely at the more detailed command line it prints, you can see a gap in the argument list where the number of benchmark iterations should be.

For now, you can work around this problem by invoking that command line by hand, with that gap filled in.

@palimondo
Copy link
Mannequin Author

palimondo mannequin commented Mar 25, 2017

I did try doing a clean build as privately suggested by @airspeedswift, but it didn’t help.

@airspeedswift
Copy link
Member

@swift-ci create

@palimondo
Copy link
Mannequin Author

palimondo mannequin commented Apr 11, 2017

As suggested by @gottesmm on swift-dev, I have been pasting a huge multiline garbage to my command line every time I need to run benchmark… I also have to remember to run the build before hand. Who do I bribe to get this working?

@palimondo
Copy link
Mannequin Author

palimondo mannequin commented Jun 28, 2018

Running build-script -R -B is working for me with the current version on master. Closing.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@airspeedswift @swift-ci