New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-4517] Teach the driver (and frontend?) to handle response files #47094
Comments
The compiler doesn't handle response files at all. line-directive expands them. I'm not sure what you're trying to do, either. You can't pass -primary-file with -Xfrontend. It has to go before the particular file that's the primary one. |
That is what I suspected, and it's absolutely, obviously, the wrong design. This means any Windows users who don't want to use line-directive can't build swift code if the command line gets too long.
I'm trying to do what Doug suggested.
It was going before the file that was the primary one. That doesn't make it exclusive with |
/cc erg (JIRA User) this is what I was talking about the other day. |
-Xfrontend arguments are additional arguments to pass to the frontend; they have nothing to do with the non-Xfrontend arguments you pass. Please don't try to play games with the driver. |
Oh, and the compiler doesn't handle response files because the correct way to handle response files would be to accept any arguments, not just input files, and that's Difficult To Implement. |
I have nothing against doing it, though. |
llvm::cl::ExpandResponseFiles will probably help here. |
Retitled to reflect the actual feature we can do. Inserting -primary-file via -Xfrontend just isn't ever going to be safe or supported. |
Comment by Austin Belknap (JIRA) Addressed this issue in PR: #15853. Still needs review. |
Cherry-picked Austin's changes to the 4.2 branch: #17409 |
Additional Detail from JIRA
md5: e57ec2457f89238a26e71b98a5cb32cf
is duplicated by:
relates to:
Issue Description:
I tried modifying the command-line that builds the standard library to specify a primary file, and it wouldn't work until I manually listed all the files instead of using
@<responsefile>.txt
The text was updated successfully, but these errors were encountered: