Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-4701] Starter: better diagnostics for multi-line string literals #47278

Closed
milseman mannequin opened this issue Apr 26, 2017 · 6 comments
Closed

[SR-4701] Starter: better diagnostics for multi-line string literals #47278

milseman mannequin opened this issue Apr 26, 2017 · 6 comments
Assignees
@beccadax
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers parser Area → compiler: The legacy C++ parser

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented Apr 26, 2017

Previous ID SR-4701
Radar rdar://problem/31870223
Original Reporter @milseman
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, Parser, StarterBug
Assignee @beccadax
Priority Medium

md5: 2c563c329008f799d4167ff029ed5da6

Issue Description:

Multi-line string literals are in, but we need better diagnostics such as notes telling why the literal is invalid, and in some cases fixits.

Potential way to attack this:

  1. For each comment (that doesn't start with "expected-error" in https://github.com/apple/swift/blob/master/test/Parse/multiline_errors.swift, make a note to help inform the user why the literal is invalid.
  2. When it makes sense, also add a fixit (e.g. if it's obvious that a line needs extra indentation).
@milseman
Copy link
Mannequin Author

milseman mannequin commented Apr 26, 2017

From: #8813 (review)

@beccadax
Copy link
Contributor

If I understand this correctly, you would like each of the cases in Parse/multiline_errors.swift to have a more specific error message and perhaps a fix-it where appropriate, right? That sounds like something I could tackle.

@milseman
Copy link
Mannequin Author

milseman mannequin commented Apr 27, 2017

Correct, let me know if I can help. I can also be the reviewer for any PRs and can help there as well.

@tkremenek
Copy link
Member

@swift-ci create

@beccadax
Copy link
Contributor

beccadax commented May 1, 2017

See PR 9148: #9148

@beccadax
Copy link
Contributor

beccadax commented May 8, 2017

PR 9148 has been merged.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beccadax beccadax

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers parser Area → compiler: The legacy C++ parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beccadax @tkremenek