Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-4814] Smoke benchmark optimization #47391

Closed
dabrahams opened this issue May 6, 2017 · 3 comments
Closed

[SR-4814] Smoke benchmark optimization #47391

dabrahams opened this issue May 6, 2017 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. performance

Comments

@dabrahams
Copy link
Collaborator

Previous ID SR-4814
Radar rdar://problem/32029925
Original Reporter @dabrahams
Type Bug
Status Closed
Resolution Duplicate
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug, Performance
Assignee None
Priority Medium

md5: 6c1911952bff35f46499c394765f59ed

duplicates:

  • SR-4669 Add a Benchmark_Driver --rerun N option

Issue Description:

For smoke benchmarks (and maybe regular benchmarks too) we should follow a procedure where we quickly run very few iterations and discard the tests that show no change, then run the rest of the benchmarks for more iterations, and repeat the process as long as it is profitable to do so. This would help eliminate what we currently see in smoke benchmarks: differences are often reported that can easily be debunked by another pass at the tests.

/cc @palimondo

@dabrahams
Copy link
Collaborator Author

@swift-ci create

@palimondo
Copy link
Mannequin

palimondo mannequin commented May 6, 2017

Do I understand this issue correctly as use the --rerun option (SR-4669) in swift-ci? If so, let's block this issue in that one and I would appreciate a contact person for the swift-ci. From the outside it appears as opaque bot on github that ignores me...

@dabrahams
Copy link
Collaborator Author

@palimondo Actually this looks like (basically) a dup of SR-4669 to me. I didn't realize someone had already proposed that. Do you see anything substantial in this bug that isn't in that one? If not, let's close it.

As for a swift-ci contact, I think @shahmishal is the right person to work with.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. performance
Projects
None yet
Development

No branches or pull requests

1 participant