Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-4824] Add tests to check Collection constraints are being enforced #47401

Open
airspeedswift opened this issue May 7, 2017 · 2 comments
Open
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. good first issue Good for newcomers standard library Area: Standard library umbrella

Comments

@airspeedswift
Copy link
Member

Previous ID SR-4824
Radar rdar://problem/32134714
Original Reporter @airspeedswift
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee djwbrown (JIRA)
Priority Medium

md5: 6b6aabc9be01be2d9974ed98c3c057f8

Issue Description:

#9379 removed tests confirming collection's associated types conformed to appropriate protocols e.g. MutableCollection.SubSequence: MutableCollection. Now the compiler is enforcing these, so they were just generating warnings.

They should be replaced by tests checking the compiler is enforcing these rules (by trying to create invalid collections and checking the error messages).

@airspeedswift
Copy link
Member Author

@swift-ci create

@swift-ci
Copy link
Collaborator

Comment by Dylan Brown (JIRA)

I see the changes referenced here #9379 have been reverted and the original tests replaced c03b14e. Is this topic on hold, or is there a more recent PR to reference? Thanks!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. good first issue Good for newcomers standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

2 participants