Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5040] Convert "exclude" related functional tests to unit test #5001

Closed
ankitspd opened this issue May 29, 2017 · 6 comments
Closed

[SR-5040] Convert "exclude" related functional tests to unit test #5001

ankitspd opened this issue May 29, 2017 · 6 comments
Labels
bug

Comments

@ankitspd
Copy link
Member

Previous ID SR-5040
Radar None
Original Reporter @aciidb0mb3r
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: c5a6f7f0bb05cb7ab9788c5412465b6a

Issue Description:

We have five functional tests to test "exclude" property. They are from the era when unit tests were not possible but now we should be able to remove them and merge with the existing unit tests.

testManifestExcludes1, testManifestExcludes2, testManifestExcludes3, testManifestExcludes4, testManifestExcludes5
@swift-ci
Copy link
Contributor

Comment by Shintaro Katafuchi (JIRA)

Can I work on the issue?

And before getting started do you have the exact output picture in your mind?😃 @aciidb0mb3r

@swift-ci
Copy link
Contributor

swift-ci commented Sep 4, 2017

Comment by Berta Devant (JIRA)

hotchemi (JIRA User) are you still working on this?

@swift-ci
Copy link
Contributor

swift-ci commented Sep 5, 2017

Comment by Shintaro Katafuchi (JIRA)

bertadevant (JIRA User) Nope I haven't done anything so far.

Actually I don't imagine entire picture as for how to fix that so it'd be better to ask @aciidb0mb3r, and now it is I guess.

@ankitspd
Copy link
Member Author

ankitspd commented Sep 5, 2017

This should be fairly straight forward to do. There are several examples in `PackageBuilderV4Tests.swift` but feel free to ask any doubts!

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2017

Comment by Tiago Martinho (JIRA)

Sorry @aciidb0mb3r, I don't find the following functional tests to migrate them into unit tests:

"testManifestExcludes1, testManifestExcludes2, testManifestExcludes3, testManifestExcludes4, testManifestExcludes5"

@ankitspd
Copy link
Member Author

ankitspd commented Oct 6, 2017

Ah, I resolved this while improving our testing infrastructure. Sorry I forgot to update this bug.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankitspd @swift-ci