Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5247] Add the new spellings for the *WithAccuracy assertion functions #371

Closed
briancroom opened this issue Jun 17, 2017 · 1 comment
Closed

[SR-5247] Add the new spellings for the *WithAccuracy assertion functions #371

briancroom opened this issue Jun 17, 2017 · 1 comment
Assignees
@briancroom
Labels
Improvement XCTest

Comments

@briancroom
Copy link
Collaborator

Previous ID SR-5247
Radar rdar://problem/32828908
Original Reporter @briancroom
Type Improvement
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s XCTest
Labels Improvement
Assignee @briancroom
Priority Medium

md5: 0c195bc6b88550abf01cdc1a06ea5065

Issue Description:

This is to bring Corelibs XCTest in line with changes made in the main XCTest Swift overlay for Xcode 9.

XCTAssertEqualWithAccuracy and XCTAssertNotEqualWithAccuracy are now deprecated in favor of XCTAssertEqual(::accuracy:file:line🙂 and XCTAssertNotEqual(::accuracy:file:line🙂.

This fixes an inconsistency where XCTAssertEqualWithAccuracy had accuracy: as a named parameter, but XCTAssertNotEqualWithAccuracy had it unnamed.
@briancroom
Copy link
Collaborator Author

PR: #193

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briancroom briancroom

Labels
Improvement XCTest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@briancroom