Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-540] eliminate the .cpp.gyb files from the source tree #43157

Open
lattner mannequin opened this issue Jan 14, 2016 · 2 comments
Open

[SR-540] eliminate the .cpp.gyb files from the source tree #43157

lattner mannequin opened this issue Jan 14, 2016 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers

Comments

@lattner
Copy link
Mannequin

lattner mannequin commented Jan 14, 2016

Previous ID SR-540
Radar None
Original Reporter @lattner
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ff02b1c09cc812ba86f097ddd5c3cf2d

Issue Description:

Gyb is a necessary artifact used in the standard library and test suite due to Swift not having a preprocessor. C++ on the other hand DOES have a preprocessor, so we should definitely not use gyb for .cpp files, we should use ".def" files consistently. Unfortunately we are using it in a couple of cases:

lib/Basic/UnicodeExtendedGraphemeClusters.cpp.gyb
stdlib/public/stubs/UnicodeExtendedGraphemeClusters.cpp.gyb
unittests/Basic/UnicodeGraphemeBreakTest.cpp.gyb

These should switch to using the C preprocessor.

@jtbandes
Copy link
Collaborator

These files are making pretty heavy use of Python code via GYBUnicodeDataUtils.py. Is there really a good reason to switch them to something else? (Even if so, the C preprocessor probably wouldn't be a good fit.)

@dabrahams
Copy link
Collaborator

I'm sure @lattner will get around to doing it eventually if it bugs him enough 😉

More seriously, I anticipate retiring all of those particular files for Swift 4, so it may become a non-issue on its own.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants