Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5452] SIL deserialization tests seem to be deserializing the whole stdlib #48024

Open
belkadan opened this issue Jul 14, 2017 · 1 comment
Open

[SR-5452] SIL deserialization tests seem to be deserializing the whole stdlib #48024

belkadan opened this issue Jul 14, 2017 · 1 comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself SILSerialization

Comments

@belkadan
Copy link
Contributor

Previous ID SR-5452
Radar None
Original Reporter @belkadan
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, SILSerialization, Test
Assignee None
Priority Medium

md5: 953770cbbaf84a79d6da1343053062a2

Issue Description:

I timed a recent Release+Asserts test run and found three tests easily taking the longest amount of time:

181.92s: Swift(macosx-x86_64) :: SIL/Serialization/deserialize_stdlib.sil
182.23s: Swift(macosx-x86_64) :: SIL/Serialization/deserialize_objectivec.sil
182.91s: Swift(macosx-x86_64) :: SIL/Serialization/deserialize_darwin.sil
183.87s: Swift(macosx-x86_64) :: SIL/Serialization/deserialize_coregraphics.swift

Regardless of whether deserialize_stdlib.sil should be moved to the validation tests instead, I'm surprised that the other three are taking just as long. The conclusion I came to is that they're deserializing the entire stdlib as well, which is not the point of those tests.
@belkadan
Copy link
Contributor Author

cc @gottesmm

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself SILSerialization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@belkadan