Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5500] Chatto source breakage: error: 'addGestureRecognizer' has been renamed to 'add(_:)' #48072

Closed
lplarson opened this issue Jul 18, 2017 · 10 comments
Closed

[SR-5500] Chatto source breakage: error: 'addGestureRecognizer' has been renamed to 'add(_:)' #48072

lplarson opened this issue Jul 18, 2017 · 10 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. source compatibility

Comments

@lplarson
Copy link
Member

Previous ID SR-5500
Radar None
Original Reporter @lplarson
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Bug, SourceCompatibility
Assignee None
Priority Medium

md5: faf65706c13a4241979c7fe61752d08b

Issue Description:

To reproduce:

  1. Install latest GM/Beta Xcode
  2. $ git clone git@github.com:apple/swift-source-compat-suite.git
  3. $ cd swift-source-compat-suite

To build Swift from scratch before testing:
4. $ ./reproduce.py master --project-path Chatto

Or if you've already built Swift:
4. $ ./reproduce.py master --project-path Chatto --swiftc path/to/swiftc

https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/822/artifact/swift-source-compat-suite/FAIL_BuildXcodeWorkspaceScheme_Chatto-_ChattoApp_generic-platform-iOS.log

CompileSwift normal arm64
    cd /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/Pods
    /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swift -frontend -c /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/AccessoryViewRevealer.swift "/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/Chat Items/BaseChatItemPresenter.swift" /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController+AccessoryViewRevealer.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController+Changes.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController+Presenters.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController+Scrolling.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/BaseChatViewControllerView.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/ChatCollectionViewLayout.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/ChatDataSourceProtocol.swift "/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/Chat Items/ChatItemCompanion.swift" /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/ChatItemPresenterFactory.swift "/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/Chat Items/ChatItemProtocolDefinitions.swift" /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/CollectionChanges.swift "/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/Chat Items/DummyChatItemPresenter.swift" /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/KeyboardTracker.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ReadOnlyOrderedDictionary.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/SerialTaskQueue.swift /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/Utils.swift -target arm64-apple-ios8.0 -Xllvm -aarch64-use-tbi -enable-objc-interop -sdk /Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.0.sdk -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Products/Release-iphoneos/Chatto -F /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Products/Release-iphoneos/Chatto -g -import-underlying-module -module-cache-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/ModuleCache -profile-generate -profile-coverage-mapping -swift-version 3 -D COCOAPODS -serialize-debugging-options -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Chatto-generated-files.hmap -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Chatto-own-target-headers.hmap -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Chatto-all-non-framework-target-headers.hmap -Xcc -ivfsoverlay -Xcc /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/all-product-headers.yaml -Xcc -iquote -Xcc /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Chatto-project-headers.hmap -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Products/Release-iphoneos/Chatto/include -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/Pods/Headers/Private -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/Pods/Headers/Public -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/DerivedSources/arm64 -Xcc -I/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/DerivedSources -Xcc -DPOD_CONFIGURATION_RELEASE=1 -Xcc -DCOCOAPODS=1 -Xcc -ivfsoverlay -Xcc /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/unextended-module-overlay.yaml -Xcc -working-directory/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/Pods -emit-module-doc-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/Chatto.swiftdoc -serialize-diagnostics-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/AccessoryViewRevealer.dia -O -module-name Chatto -emit-module-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/Chatto.swiftmodule -emit-objc-header-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/Chatto-Swift.h -emit-dependencies-path /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/AccessoryViewRevealer.d -num-threads 4 -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/AccessoryViewRevealer.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatItemPresenter.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatViewController+AccessoryViewRevealer.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatViewController+Changes.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatViewController+Presenters.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatViewController+Scrolling.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatViewController.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/BaseChatViewControllerView.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/ChatCollectionViewLayout.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/ChatDataSourceProtocol.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/ChatItemCompanion.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/ChatItemPresenterFactory.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/ChatItemProtocolDefinitions.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/CollectionChanges.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/DummyChatItemPresenter.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/KeyboardTracker.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/ReadOnlyOrderedDictionary.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/SerialTaskQueue.o -o /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/ChattoApp/build/Build/Intermediates.noindex/Pods.build/Release-iphoneos/Chatto.build/Objects-normal/arm64/Utils.o
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/AccessoryViewRevealer.swift:59:29: error: 'addGestureRecognizer' has been renamed to 'add(_:)'
        self.collectionView.addGestureRecognizer(self.panRecognizer)
                            ^~~~~~~~~~~~~~~~~~~~
                            add
UIKit.UIView:8:15: note: 'addGestureRecognizer' was obsoleted in Swift 3
    open func addGestureRecognizer(_ gestureRecognizer: UIGestureRecognizer)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/Collaborators/AccessoryViewRevealer.swift:66:29: error: 'removeGestureRecognizer' has been renamed to 'remove(_:)'
        self.collectionView.removeGestureRecognizer(self.panRecognizer)
                            ^~~~~~~~~~~~~~~~~~~~~~~
                            remove
UIKit.UIView:13:15: note: 'removeGestureRecognizer' was obsoleted in Swift 3
    open func removeGestureRecognizer(_ gestureRecognizer: UIGestureRecognizer)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController+Presenters.swift:87:15: warning: parameter of 'collectionView(_:shouldShowMenuForItemAt:)' has different optionality than expected by protocol 'UICollectionViewDelegate'
    open func collectionView(_ collectionView: UICollectionView, shouldShowMenuForItemAt indexPath: IndexPath?) -> Bool {
              ^                                                                                              ~
                                                                                                             
UIKit.UICollectionViewDelegate:49:26: note: requirement 'collectionView(_:shouldShowMenuForItemAt:)' declared here
    optional public func collectionView(_ collectionView: UICollectionView, shouldShowMenuForItemAt indexPath: IndexPath) -> Bool
                         ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController+Presenters.swift:95:15: warning: parameter of 'collectionView(_:canPerformAction:forItemAt:withSender:)' has different optionality than expected by protocol 'UICollectionViewDelegate'
    open func collectionView(_ collectionView: UICollectionView, canPerformAction action: Selector, forItemAt indexPath: IndexPath?, withSender sender: Any?) -> Bool {
              ^                                                                                                                   ~
                                                                                                                                  
UIKit.UICollectionViewDelegate:53:26: note: requirement 'collectionView(_:canPerformAction:forItemAt:withSender:)' declared here
    optional public func collectionView(_ collectionView: UICollectionView, canPerformAction action: Selector, forItemAt indexPath: IndexPath, withSender sender: Any?) -> Bool
                         ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:89:29: error: 'addGestureRecognizer' has been renamed to 'add(_:)'
        self.collectionView.addGestureRecognizer(UITapGestureRecognizer(target: self, action: #selector(BaseChatViewController.userDidTapOnCollectionView)))
                            ^~~~~~~~~~~~~~~~~~~~
                            add
UIKit.UIView:8:15: note: 'addGestureRecognizer' was obsoleted in Swift 3
    open func addGestureRecognizer(_ gestureRecognizer: UIGestureRecognizer)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:123:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.view, attribute: .top, relatedBy: .equal, toItem: self.collectionView, attribute: .top, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:124:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.view, attribute: .leading, relatedBy: .equal, toItem: self.collectionView, attribute: .leading, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:125:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.view, attribute: .bottom, relatedBy: .equal, toItem: self.collectionView, attribute: .bottom, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:126:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.view, attribute: .trailing, relatedBy: .equal, toItem: self.collectionView, attribute: .trailing, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:146:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.inputContainer, attribute: .top, relatedBy: .greaterThanOrEqual, toItem: self.topLayoutGuide, attribute: .bottom, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:147:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.view, attribute: .leading, relatedBy: .equal, toItem: self.inputContainer, attribute: .leading, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:148:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(NSLayoutConstraint(item: self.view, attribute: .trailing, relatedBy: .equal, toItem: self.inputContainer, attribute: .trailing, multiplier: 1, constant: 0))
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:150:19: error: 'addConstraint' has been renamed to 'add(_:)'
        self.view.addConstraint(self.inputContainerBottomConstraint)
                  ^~~~~~~~~~~~~
                  add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:154:29: error: 'addConstraint' has been renamed to 'add(_:)'
        self.inputContainer.addConstraint(NSLayoutConstraint(item: self.inputContainer, attribute: .top, relatedBy: .equal, toItem: inputView, attribute: .top, multiplier: 1, constant: 0))
                            ^~~~~~~~~~~~~
                            add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:155:29: error: 'addConstraint' has been renamed to 'add(_:)'
        self.inputContainer.addConstraint(NSLayoutConstraint(item: self.inputContainer, attribute: .leading, relatedBy: .equal, toItem: inputView, attribute: .leading, multiplier: 1, constant: 0))
                            ^~~~~~~~~~~~~
                            add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:156:29: error: 'addConstraint' has been renamed to 'add(_:)'
        self.inputContainer.addConstraint(NSLayoutConstraint(item: self.inputContainer, attribute: .bottom, relatedBy: .equal, toItem: inputView, attribute: .bottom, multiplier: 1, constant: 0))
                            ^~~~~~~~~~~~~
                            add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Chatto/Chatto/Source/ChatController/BaseChatViewController.swift:157:29: error: 'addConstraint' has been renamed to 'add(_:)'
        self.inputContainer.addConstraint(NSLayoutConstraint(item: self.inputContainer, attribute: .trailing, relatedBy: .equal, toItem: inputView, attribute: .trailing, multiplier: 1, constant: 0))
                            ^~~~~~~~~~~~~
                            add
UIKit.UIView:8:15: note: 'addConstraint' was obsoleted in Swift 3
    open func addConstraint(_ constraint: NSLayoutConstraint)
              ^
@lplarson
Copy link
Member Author

The project owner needs to resolve this since the API was obsoleted.

@lplarson
Copy link
Member Author

badoo/Chatto#335

@belkadan
Copy link
Contributor

This is almost certainly an SDK bug.

@belkadan
Copy link
Contributor

(In particular, I wonder if something happened to UIKit's API notes.)

@belkadan
Copy link
Contributor

I also had a Radar previously about a failure like this appearing and then vanishing.

@belkadan
Copy link
Contributor

Yep, the next build has a different project failing. :-( https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/823/

@dabrahams
Copy link
Collaborator

Yes, this has vanished. @lplarson can we revert apple/swift-source-compat-suite@097cec0
?

Thanks

@nevil
Copy link

nevil commented Jul 19, 2017

Not sure if this is helpful...
In Xcode 9 beta 1 the StoreKit apinotes seemed to be broken.
resume(_:) was changed to resumeDownloads().
I reported radar 32729211 for this.

Also the the SKError bridging didn't work. Radar 32729058.

The StoreKit issues were resolved in a later beta.

@dabrahams
Copy link
Collaborator

apple/swift-source-compat-suite#59 un-XFAILs it

@lplarson
Copy link
Member Author

Both XFAILs have been removed.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. source compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nevil @dabrahams @belkadan @lplarson