Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5643] Adopt Swift 4 API adjustments in XCTest #369

Closed
glessard opened this issue Aug 8, 2017 · 7 comments
Closed

[SR-5643] Adopt Swift 4 API adjustments in XCTest #369

glessard opened this issue Aug 8, 2017 · 7 comments
Assignees
@briancroom
Labels
bug XCTest

Comments

@glessard
Copy link

glessard commented Aug 8, 2017

Previous ID SR-5643
Radar rdar://problem/33778877
Original Reporter @glessard
Type Bug
Status Closed
Resolution Done
Environment

ubuntu 16.04, swift-4.0-DEVELOPMENT-SNAPSHOT-2017-08-04-a

Additional Detail from JIRA
Votes 0
Component/s XCTest
Labels Bug
Assignee @briancroom
Priority Medium

md5: d9de2b31a27499cd80ba9741088859ea

Issue Description:

XCTestCase.defaultPerformanceMetrics() has not been updated yet in the swift-corelibs-xctest project, making it inconsistent with Xcode's spelling, where it has become a class var.

Similarly, the old XCTPerformanceMetric_WallClockTime has become XCTPerformanceMetric.wallClockTime in Xcode, but is unchanged in swift-corelibs-xctest.

There are some other API adjustments in the XCTest API, such as moving `UInt` types to `Int`, that also should be adopted in swift-corelibs-xctest.
@belkadan
Copy link

belkadan commented Aug 8, 2017

@swift-ci create

@briancroom
Copy link
Collaborator

Thanks for filing this, @glessard. There are a few other API adjustments that were made in XCTest for Swift 4 as well which I will use this bug to track adopting.

@briancroom
Copy link
Collaborator

#198

@briancroom
Copy link
Collaborator

This has landed on master.

@glessard
Copy link
Author

Looking forward to it. Thanks!

@glessard
Copy link
Author

Will this make it to the 4.0 release for Linux?

(It hasn't made it to the August 27th 4.0 snapshot)

@glessard
Copy link
Author

glessard commented Mar 5, 2019

Fixed in 4.1

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briancroom briancroom

Labels
bug XCTest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glessard @belkadan @briancroom