Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5746] Refactoring action to simplify long integer format #48316

Closed
akyrtzi opened this issue Aug 23, 2017 · 4 comments
Closed

[SR-5746] Refactoring action to simplify long integer format #48316

akyrtzi opened this issue Aug 23, 2017 · 4 comments
Assignees
@nkcsgexi
Labels
compiler The Swift compiler in itself feature A feature request or implementation good first issue Good for newcomers refactoring Area → source tooling: refactoring source tooling Area: IDE support, SourceKit, and other source tooling

Comments

@akyrtzi
Copy link
Member

akyrtzi commented Aug 23, 2017

Previous ID SR-5746
Radar None
Original Reporter @akyrtzi
Type New Feature
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels New Feature, Refactoring, StarterProposal
Assignee @nkcsgexi
Priority Medium

md5: ded7e0cbfce404b1f0115468d12bc97e

Issue Description:

Implement action to convert from:

var a = 1000000

to

var a = 1_000_000
@nkcsgexi
Copy link
Member

hhennies (JIRA User) are you actively working on this? Let me know if you need any help.

@swift-ci
Copy link
Collaborator

Comment by Hugo Hennies (JIRA)

I was but a ton of stuff got in the way. I will remove myself from this issue now, maybe later I'll try it again. Really sorry for the trouble.

@nkcsgexi
Copy link
Member

Opened a PR to implement this action: #11711

@nkcsgexi
Copy link
Member

Merged the implementation as

53585a5

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added compiler The Swift compiler in itself good first issue Good for newcomers feature A feature request or implementation source tooling Area: IDE support, SourceKit, and other source tooling and removed new feature StarterProposal labels Nov 11, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkcsgexi nkcsgexi

Labels
compiler The Swift compiler in itself feature A feature request or implementation good first issue Good for newcomers refactoring Area → source tooling: refactoring source tooling Area: IDE support, SourceKit, and other source tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akyrtzi @nkcsgexi @swift-ci @AnthonyLatsis