Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type #48555

Closed
xedin opened this issue Sep 26, 2017 · 1 comment
Closed

[SR-5998] AsyncNinja source breakage: label mismatch between closure return and contextual type #48555

xedin opened this issue Sep 26, 2017 · 1 comment
Assignees
@lplarson
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself source compatibility type checker Area → compiler: Semantic analysis

Comments

@xedin
Copy link
Member

xedin commented Sep 26, 2017

Previous ID SR-5998
Radar None
Original Reporter @xedin
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, SourceCompatibility, TypeChecker
Assignee @lplarson
Priority Medium

md5: 942e737fd1cf2fffc22d39b41c71eb36

Issue Description:

Changes in PR #12072 fixed compiler bug related to enforcing of structural checks between return type and contextual type, which uncovered a bug in AsyncNinja project where return type of the closure doesn't match contextual type - `value:` vs. `date:` labels.

/Users/buildnode/jenkins/workspace-private/swift-PR-source-compat-suite/project_cache/AsyncNinja/Sources/iOS.swift:653:40: error: expression type '(date: _, isAnimated: _)' is ambiguous without more context
 customGetter: \{ (date: $0.value, isAnimated: false) },
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@lplarson
Copy link
Member

lplarson commented Oct 2, 2017

This has been resolved. The project maintainer updated the project and submitted a PR to the source compatibility suite.

apple/swift-source-compat-suite#74

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lplarson lplarson

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself source compatibility type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xedin @lplarson