Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-604] llbuild should understand symbolic links more precisely #814

Open
ddunbar opened this issue Jan 23, 2016 · 0 comments
Open

[SR-604] llbuild should understand symbolic links more precisely #814

ddunbar opened this issue Jan 23, 2016 · 0 comments

Comments

@ddunbar
Copy link
Member

ddunbar commented Jan 23, 2016

Previous ID SR-604
Radar None
Original Reporter @ddunbar
Type Bug
Additional Detail from JIRA
Votes 0
Component/s llbuild
Labels Bug
Assignee None
Priority Medium

md5: d36aca20d0c383ff9b730a94e12b72ea

Issue Description:

In the following example, it isn't clear that llbuild should rebuild the link on the second iteration – the semantics of the build file are such that the ln is up to date, but because it doesn't exist, and we `stat()`, then we rebuild

$ cat t.llbuild 
client:
  name: basic
  version: 0

targets:
  "": ["foo-stat"]

commands:
  C1:
    tool: shell
    outputs: ["foo"]
    args: ln -sf does/not/exist foo

  C2:
    tool: shell
    inputs: ["foo"]
    outputs: ["foo-stat"]
    args: stat -s foo | tee foo-stat

$ llbuild buildsystem build -f t.llbuild 
/bin/sh -c "ln -sf does/not/exist foo"
/bin/sh -c "stat -s foo | tee foo-stat"
st_dev=16777225 st_ino=14250438 st_mode=0120755 st_nlink=1 st_uid=501 st_gid=0 st_rdev=0 st_size=14 st_atime=1453531949 st_mtime=1453531949 st_ctime=1453531949 st_birthtime=1453531949 st_blksize=4096 st_blocks=8 st_flags=0

$ llbuild buildsystem build -f t.llbuild 
/bin/sh -c "ln -sf does/not/exist foo"

We should probably have a way for the client to specify the appropriate semantics to use for file based nodes. It isn't clear to me yet whether that should be an attribute tied to the file or the command, though.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant