Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6071] compiler-rt no longer optional? #48628

Closed
davezarzycki opened this issue Oct 5, 2017 · 4 comments
Closed

[SR-6071] compiler-rt no longer optional? #48628

davezarzycki opened this issue Oct 5, 2017 · 4 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script

Comments

@davezarzycki
Copy link
Collaborator

Previous ID SR-6071
Radar None
Original Reporter @davezarzycki
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s
Labels Bug, BuildScript
Assignee george.karpenkov (JIRA)
Priority Medium

md5: b07b6a3686b2f055af79914e8aaccac7

Issue Description:

Until a couple months ago, ./utils/build-script -t used to succeed. Now it fails like so:

Failing Tests (2):
    Swift(macosx-x86_64) :: Fuzzing/fuzzer_test.swift
    Swift(macosx-x86_64) :: Fuzzing/fuzzer_test_simpler.swift 

The workaround is to build with compiler-rt. That being said, compiler-rt is listed as "optional":

$ ./utils/build-script -help | grep compiler-rt
/compiler-rt (optional)
$

If compiler-rt is no longer optional, then the build-script needs updating. If compiler-rt should still be optional, then the test suite needs fixing.

@belkadan
Copy link
Contributor

belkadan commented Oct 5, 2017

cc george.karpenkov (JIRA User)

@swift-ci
Copy link
Collaborator

swift-ci commented Oct 5, 2017

Comment by George Karpenkov (JIRA)

I'll take a look. These tests should probably only be run if the needed file exists.

@swift-ci
Copy link
Collaborator

swift-ci commented Oct 5, 2017

Comment by George Karpenkov (JIRA)

Tracked in rdar://34844255

@swift-ci
Copy link
Collaborator

Comment by George Karpenkov (JIRA)

#12435

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script
Projects
None yet
Development

No branches or pull requests

3 participants