[SR-6132] Dispatch fails to build when Ninja is not installed #671
Comments
|
Docker file for reproduction: FROM ubuntu:16.04
RUN mkdir /swift-source
RUN apt-get update && apt-get install -y git cmake clang python uuid-dev libicu-dev icu-devtools libbsd-dev libedit-dev libxml2-dev libsqlite3-dev swig libpython-dev libncurses5-dev pkg-config libblocksruntime-dev libcurl4-openssl-dev autoconf libtool systemtap-sdt-dev libbsd-dev libunwind-dev zlib1g-dev
RUN git clone https://github.com/apple/swift.git swift-source/swift
RUN /swift-source/swift/utils/update-checkout --clone
CMD /bin/bashAfter running, execute /swift-source/swift/utils/update-checkout --clone to get up-to-date, and then /swift-source/swift/utils/build-script -R |
|
As a workaround, it is possible to symlink /usr/bin/ninja -> /swift-source/build/Ninja-ReleaseAssert/ninja-build/ninja, which will then subsequently find the build tool. But it should be passed through the ninja-bin argument for dependent builds. |
|
The swift_build_support/cmake.py file has the following: if args.build_ninja and args.cmake_generator == 'Ninja': It looks like this isn't being passed down to whatever process gets kicked off for the libdispatch configure. |
|
I think that PR#12400 should help with that. |
|
Looks like apple/swift#12400 solves the problem, will close when it's merged. Thanks for the quick turnaround! |
Additional Detail from JIRA
md5: 5316249dfb91c3e406967036ecf9f866
Issue Description:
From a local Swift instance running on Ubuntu 16:04 but without Ninja installed:
[772/847] Performing configure step for 'libdispatch'
FAILED: tools/SourceKit/libdispatch-prefix/src/libdispatch-stamp/libdispatch-configure
cd /swift-source/build/Ninja-ReleaseAssert/libdispatch-linux-x86_64 && /usr/bin/cmake -DCMAKE_C_COMPILER=/swift-source/build/Ninja-ReleaseAssert/llvm-linux-x86_64/bin/clang -DCMAKE_CXX_COMPILER=/swift-source/build/Ninja-ReleaseAssert/llvm-linux-x86_64/bin/clang++ -DCMAKE_SWIFT_COMPILER=/swift-source/build/Ninja-ReleaseAssert/swift-linux-x86_64/bin/swiftc -DCMAKE_INSTALL_PREFIX=/swift-source/build/Ninja-ReleaseAssert/swift-linux-x86_64/tools/SourceKit/libdispatch-prefix -DENABLE_SWIFT=YES -GNinja /swift-source/swift-corelibs-libdispatch && /usr/bin/cmake -E touch /swift-source/build/Ninja-ReleaseAssert/swift-linux-x86_64/tools/SourceKit/libdispatch-prefix/src/libdispatch-stamp/libdispatch-configure
CMake Error: CMake was unable to find a build program corresponding to "Ninja". CMAKE_MAKE_PROGRAM is not set. You probably need to select a different build tool.
Although we've built Ninja by this point, there is no Ninja on the PATH that can be executed.
The text was updated successfully, but these errors were encountered: