Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6154] Add support for LLVM_REVERSE_ITERATION and use it to uncover non-determinism #48709

Open
gottesmm opened this issue Oct 15, 2017 · 1 comment
Labels
compiler The Swift compiler in itself good first issue Good for newcomers task

Comments

@gottesmm
Copy link
Member

Previous ID SR-6154
Radar None
Original Reporter @gottesmm
Type Task
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Task, StarterBug
Assignee None
Priority Medium

md5: c398112976749549e4be99b1549c89f1

Issue Description:

Upstream LLVM added an option called LLVM_REVERSE_ITERATION. This causes unordered collections to iterate in the reverse order. This can be used to uncover places in the compiler where we are using unordered collections in ways that can result in non-deterministic output.

The task is this:

1. Add build-script support and cmake support for LLVM_REVERSE_ITERATION.
2. Define a preset that does (for starters) a simple build with reverse iteration enabled. My suggestion: make sure that you specify a build directory with the name reverse iteration in it it will make binary diffing easier.
2. Add a script called ./utils/build-root-compare that performs the binary comparison given two build roots that supports an externally specified file containing an XFAIL list of binary paths.
3. Perform an initial binary comparisons in between an LLVM_REVERSE_ITERATION and a non-LLVM_REVERSE_ITERATION and XFAIL any differences.
4. At this point, we should have an iteration/reverse iteration build that can be put on a bot and maintain the current state.
5. Start going through the list of XFAILs investigating where these issues are coming from, with the bot keeping previous work from breaking.

@gottesmm
Copy link
Member Author

@swift-ci

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself good first issue Good for newcomers task
Projects
None yet
Development

No branches or pull requests

1 participant