[SR-6196] New Build System incorrect substitutes variables in Info.plist #791
Comments
|
Sorry, llbuild is just the low-level piece of the build system; the part that's messing up your Info.plist is still part of Xcode. Please file an issue at https://bugreport.apple.com instead. I'm afraid we don't have enough stickers for everyone, but there are some good shirts at the store at 1 Infinite Loop. :-) |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Xcode 9.0.1 with the New Build System enabled.
This project where this happens is open source and can be found at https://github.com/mozilla-mobile/firefox-ios
We are happy to assist with more details.
Additional Detail from JIRA
md5: 4cad5e8fa310acd30538a0f8adc85a81
Issue Description:
This one took us a few days to narrow down unfortunately.
With the new build system enabled, the following in the Info.plist ...
{{ <key>NSExtension</key>}}
{{ <dict>}}
{{ <key>NSExtensionAttributes</key>}}
{{ <dict>}}
{{ <key>NSExtensionActivationRule</key>}}
{{ <string>SUBQUERY ( extensionItems, $extensionItem, SUBQUERY ( $extensionItem.attachments, $attachment, ANY $attachment.registeredTypeIdentifiers UTI-CONFORMS-TO "public.url").@count == 1 ).@count == 1</string>}}
... will be transformed to ...
<key>NSExtension</key><dict><key>NSExtensionAttributes</key><dict><key>NSExtensionActivationRule</key><string>SUBQUERY ( extensionItems, $extensionItem, SUBQUERY ( , , ANY UTI-CONFORMS-TO "public.url").@count == 1 ).@count == 1</string>The problem being that the New Build System substitutes$IDENTIFIER whereas the Old Build System would only do that for $ (IDENTIFIER).
Because of the moment in the build where this happens, there is no workaround. We tried entity encoding the $ and putting things in a CDATA section, but that did not work.
We switched back to the Old Build System and this problem went away.
If we visit Cupertino, do we get some stickers as a reward? 🙂
The text was updated successfully, but these errors were encountered: