Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6488] Source Compatibility Suite: Plank and R fail with error: multiple products named '...' #4910

Closed
aschwaighofer opened this issue Nov 29, 2017 · 13 comments
Closed

[SR-6488] Source Compatibility Suite: Plank and R fail with error: multiple products named '...' #4910

aschwaighofer opened this issue Nov 29, 2017 · 13 comments
Labels
bug

Comments

@aschwaighofer
Copy link
Member

Previous ID SR-6488
Radar rdar://problem/35740248
Original Reporter @aschwaighofer
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 6374607fa519cc46d7751316cb863b49

Issue Description:

https://ci.swift.org/job/swift-master-source-compat-suite/817

$ chflags -R nouchg /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Plank
$ git -C /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Plank clean -ffdx
Removing .build/
$ git -C /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Plank rev-parse HEAD
current_sha: d69c8e6f9942c098e589a75162d3196dec183929
configured_sha: d69c8e6f9942c098e589a75162d3196dec183929
current_sha == configured_sha
$ sandbox-exec -f /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_package.sb /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swift package --disable-sandbox -C /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Plank clean
warning: '--chdir/-C' option is deprecated; use '--package-path' instead
$ sandbox-exec -f /Users/buildnode/jenkins/workspace-private/swift-source-compat-suite-sandbox/sandbox_package.sb /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swift build --disable-sandbox -C /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Plank --verbose --configuration release
xcrun --sdk macosx --show-sdk-path
xcrun --sdk macosx --show-sdk-platform-path
xcrun --find clang
/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/bin/swiftc --driver-mode=swift -L /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/lib/swift/pm/3 -lPackageDescription -swift-version 3 -I /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/build/compat_macos/install/toolchain/usr/lib/swift/pm/3 -target x86_64-apple-macosx10.10 -sdk /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk /Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/Plank/Package.swift -fileno 5
warning: '--chdir/-C' option is deprecated; use '--package-path' instead
error: multiple products named 'plank'
@aschwaighofer
Copy link
Member Author

@DougGregor The change list has mainly your changes

@aschwaighofer
Copy link
Member Author

@swift-ci create

@DougGregor
Copy link
Member

This is due to a swiftpm change, here: #1393

@ankitspd
Copy link
Member

See PR for full discussion. I think we should disable these packages until they submit a fix.

@ankitspd
Copy link
Member

@shahmishal aschwaighofer@apple.com (JIRA User) Given the lack of policy right now, do you know who can decide what to do for this particular case?

@aschwaighofer
Copy link
Member Author

I am disabling the package here: apple/swift-source-compat-suite#106

Broken source compatibility suite have to be disable to unbreak the build. That is a policy 😉.

So in absence of a decision on your issue they will stay disabled.

For the actual policy I would raise discussion on swift-dev?

@ankitspd
Copy link
Member

Can we also notify the project owners so they can fix the issue and re-enable the projects?

Please CC swift-build-dev for any topic related to package manager.

@aschwaighofer
Copy link
Member Author

Just do be clear, I am not starting a discussion. I am just the build czar. This issue is caused by a change in swiftpm as far as I understand it. It therefore falls under swiftpm's responsibility to resolve this in my opinion.

@ankitspd
Copy link
Member

Sure. I'll go ahead and contact the project maintainers on the emails listed in the json.

@ankitspd
Copy link
Member

Huh, turns out Plank package is defined correctly, so it must be a bug in the package manager. I'll revert the package manager change and re-enable this package.

I don't know why R.swift failed and I can't see the build log for packages in the jenkins logs, is there a place to see the verbose build log?

@DougGregor
Copy link
Member

You have to look in "Build Artifacts" in the CI. Here's a link for R:

https://ci.swift.org/job/swift-master-source-compat-suite/817/artifact/swift-source-compat-suite/FAIL_BuildSwiftPackage_R-swift.log

@ankitspd
Copy link
Member

Thanks, got it.

Looks like this happens when a package is using old manifest format and there is command line target. I am reverting the swiftpm patch here and then will re-enable these packages.

@ankitspd
Copy link
Member

These projects were re-enabled here: apple/swift-source-compat-suite#108

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DougGregor @ankitspd @aschwaighofer