Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6615] Syntax highlighting wrong for macOS check #49164

Closed
louisdh opened this issue Dec 14, 2017 · 3 comments
Closed

[SR-6615] Syntax highlighting wrong for macOS check #49164

louisdh opened this issue Dec 14, 2017 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@louisdh
Copy link
Contributor

louisdh commented Dec 14, 2017

Previous ID SR-6615
Radar None
Original Reporter @louisdh
Type Bug
Status Closed
Resolution Done

Attachment: Download

Environment

Xcode Version 9.2 (9C40b)
Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2)
Target: x86_64-apple-macosx10.9

Additional Detail from JIRA
Votes 0
Component/s Source Tooling
Labels Bug
Assignee None
Priority Medium

md5: 24a55ea51b4244b1da40f5706867970b

Issue Description:

The following snippet results in bogus syntax highlighting:
```
#if os(macOS)
// something
#endif
```
As can be seen in the attached screenshot, "OS" has the wrong color.
@belkadan
Copy link
Contributor

Weird. @nkcsgexi, have we seen this before?

@nkcsgexi
Copy link
Member

I think we've fixed this issue on Swift master. Could you try an open source toolchain (master) to see if the coloring is correct?

@louisdh
Copy link
Contributor Author

louisdh commented Dec 19, 2017

@nkcsgexi You're right, it's fixed on master (tested with swift-DEVELOPMENT-SNAPSHOT-2017-12-18-a-osx). Thanks!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@belkadan @louisdh @nkcsgexi