Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6626] Investigate diagnostics regressions in IUO changes #49175

Closed
rudkx opened this issue Dec 16, 2017 · 3 comments
Closed

[SR-6626] Investigate diagnostics regressions in IUO changes #49175

rudkx opened this issue Dec 16, 2017 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis

Comments

@rudkx
Copy link
Member

rudkx commented Dec 16, 2017

Previous ID SR-6626
Radar rdar://problem/37047231
Original Reporter @rudkx
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee None
Priority Medium

md5: 66850f9ca88d10b3a0a41dc3a2a3bff9

Issue Description:

In
#13391
there is a commit, to enable creating disjunctions for IUOs, and it appears to regress two diagnostics that involve IUOs.

Opening this so that these can be investigated and improved.
@rudkx
Copy link
Member Author

rudkx commented Jan 31, 2018

I closed that PR but will open a new one soon to finish this off.

I believe I can get back some of the diagnostics by adding some code to cache which expression nodes are unforced IUOs, and querying this from the diagnostics.

This would also help code completion.

@rudkx
Copy link
Member Author

rudkx commented Jan 31, 2018

@swift-ci create

@hborla
Copy link
Member

hborla commented Apr 8, 2020

I think this is no longer applicable with the new diagnostics architecture

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rudkx @hborla