Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-670] Can't build llbuild with clang++ 3.4 #813

Closed
swift-ci opened this issue Feb 4, 2016 · 2 comments
Closed

[SR-670] Can't build llbuild with clang++ 3.4 #813

swift-ci opened this issue Feb 4, 2016 · 2 comments

Comments

@swift-ci
Copy link

swift-ci commented Feb 4, 2016

Previous ID SR-670
Radar None
Original Reporter jaybuff (JIRA User)
Type Bug
Status Closed
Resolution Won't Do
Additional Detail from JIRA
Votes 0
Component/s llbuild
Labels Bug
Assignee None
Priority Medium

md5: 6b1d27cc2ca1c3f1182cc9f8fba332ed

Issue Description:

llbuild's CMakeLists.txt explicitly adds -std=c++14 as a cxx flag:

    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14 -fno-rtti -fno-exceptions")

This means it can't be compiled with clang 3.4, which supports c\+\+14, but the flag to -std is called c\+\+1y

Can we just change llbuild's CMakeLists.txt to use c\+\+1y?

@belkadan
Copy link

belkadan commented Feb 4, 2016

I'm pretty sure we require Clang 3.6 as a minimum for other parts of the project, so I'm not sure it makes sense to cater to 3.4 for llbuild. (@gribozavr, confirm/deny?)

@gribozavr
Copy link
Collaborator

Yes, we require Clang 3.6 or newer, and as an exception I think we support 3.5 on FreeBSD only.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants