Attachment: Download

Issue Description:

When a library is expressly declared `type: .static` in the library's Package.swift manifest, then it seems that one should reasonably expect `swift package generate-xcodeproj` to generate an Xcode project which preserves the library as static through out the build process.

Example

The following two Swift Manager Packages (SPM) packages are both attached to this issue and also available on GitHub:

1. Static Library Depedency: `TinkerEvalStaticLib` (https://github.com/VaporExamplesLab/TinkerEvalStaticLib) used `swift package init --type library` as the starting point.

2. Command Line Executable: `TinkerEvalStaticCli` (https://github.com/VaporExamplesLab/TinkerEvalStaticCli) used `swift package init --type executable` as the starting point.

`TinkerEvalStaticLib` has one simple function and is expressly set to a type `.static` in Package.swift.

TinkerEvalStaticLib.swift

public class TinkerEvalStaticLib {
    public static func printSomething() -> String {
        let s = "Library says, 'Hello.'"
        print(s)
        return s
    }
} 

Package.swift

…
products: [
  .library(name: "TinkerEvalStaticLib", 
           type: .static, // expressly set to be a static library
           …

`TinkerEvalStaticCli` is also simple and has the static library `TinkerEvalStaticLib` as a dependency.

main.swift

import TinkerEvalStaticLib
let _ = TinkerEvalStaticLib.printSomething() 

Package.swift

…
name: "TinkerEvalStaticCli",
dependencies: [
  .package(
    url: "git@github.com:VaporExamplesLab/TinkerEvalStaticLib.git",
        .branch("master") ),
],
…

Observation

1. In the `TinkerEvalStaticCli` directory, `swift build` will create a standalone relocatable, statically linked executable.

prompt> ./TinkerEvalStaticCli_spm 
Library says, 'Hello.'

2. However, the Xcode project created with `swift package generate-xcodeproj` creates a dynamically linked executable that requires the separate library.

prompt> ./TinkerEvalStaticCli_xc 
dyld: Library not loaded: @rpath/TinkerEvalStaticLib.framework/Versions/A/TinkerEvalStaticLib
Referenced from: /Users/…/./TinkerEvalStaticCli_xc
Reason: image not found
Abort trap: 6