Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-6870] Fix SWIFTCC mangling in MSABI #49419

Closed
swift-ci opened this issue Jan 30, 2018 · 2 comments
Closed

[SR-6870] Fix SWIFTCC mangling in MSABI #49419

swift-ci opened this issue Jan 30, 2018 · 2 comments
Assignees
@compnerd
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself swift 4.0 Windows Platform: Windows

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-6870
Radar None
Original Reporter asb (JIRA User)
Type Bug
Status Closed
Resolution Done
Environment

Windows 64-bit, developer (Visual Studio) shell

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, Swift4, Windows
Assignee @compnerd
Priority Medium

md5: efca028c68c9639c7fd4a6d63a1f7d41

Issue Description:

Currently, Swift calling conventions are incorrectly mangled on Windows. To test, simply build Swift on a Windows machine and enjoy a 140 deep call-stack that shows the issue
@compnerd
Copy link
Collaborator

compnerd commented Feb 1, 2018

Initial patch for this at https://reviews.llvm.org/D42768

@compnerd
Copy link
Collaborator

compnerd commented Feb 7, 2018

Spoke with Microsoft, 'S' is reserved for the Swift CC, and this is implemented in clang now.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself swift 4.0 Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@compnerd @swift-ci