What does #sourceLocation do?

Ah right, #sourceLocation is pink like the expressiony pound-keywords. Maybe the idea is brown just for control flow, then.

@akyrtzi, thoughts?

Making it brownish will match how Xcode shows #error/#warning in C-family languages, but I'd recommend to classify those separately (maybe 'pound.diagnostic'), and leave it to the client to decide how to color. Even though that means Xcode will need an update to color it properly.

Or 'builddirective.keyword' to include #sourceLocation and any future pound-statements?

Nitpick: "builddirective" isn't a good name. The "build" in "buildconfig" refers to "checking the configuration of the thing we're building". (We also ditched that name in Swift 3 because Xcode has its own feature called "build configurations", but SourceKit requests are supposed to be stable-ish.)

How about 'pound.keyword' ?

OK!

#14742

Working through that I went with 'poundstmt.keyword' because 'pound.keyword' felt too close to "keywords that begin with pound" (including #line eg.) which is not meant here.

Hm. It's not a statement, though. (I may be being too nitpicky but "statements" can appear in certain places in the grammar.) Maybe going back to "directive"?

It is tricky - maybe try to read as 'pound keyword that introduces a statement'?

(The grammar calls these things 'compiler control statements' – I appreciate that refers to the pound-keyword and its arguments – as a production under 'statement'.)

That grammar is incorrect. They're much closer to declarations, especially in Swift 4.1 and later. But even then they can appear where neither a statement nor a declaration can appear.

(I admit that appealing to "the grammar in my head" or "the grammar defined by the current implementation of the parser" is not a great argument. But I'd rather not encode a misleading name forever.)

No it's a good note, thanks, I'm sure the documented grammar will catch up with reality. So, catching up with a previous comment of yours now, I see 'directive' could work as a term that doesn't imply anything else. Will change to that unless further ideas.

Supported by Xcode in beta 5.