[SR-7044] Possible incorrect ordering of arguments in CSApply.cpp #49592
Assignees
Labels
bug
A deviation from expected or documented behavior. Also: expected but undesirable behavior.
compiler
The Swift compiler in itself
type checker
Area → compiler: Semantic analysis
Comments
|
Xi, you added this code in 0b50648263c - can you advise to the right course of action? |
|
cc @xedin too |
|
It seems like an oversight with the consequence that it's going to suggest inserting labels incorrectly... |
|
Makes we wonder though, why do we even produce a solution if it's not going to be expressible in the AST? It seems like this should be removed and logic should go into solver to prevent forming solutions with tuple conversions which can't be expressed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: 13238fec5380e13855245c65d819d174
Issue Description:
In
swift/lib/Sema/CSApply.cpp
Lines 4869 to 4870 in d8d7edf
the function is defined as:
shouldApplyAddingLabelFixit(TuplePattern *tuplePattern, TupleType *fromTuple,
TupleType *toTuple,
However, when it is called later on in
swift/lib/Sema/CSApply.cpp
Lines 5124 to 5125 in d8d7edf
the argument to 'fromTuple' and 'toTuple' appear to be the wrong way around:
if (tupleP && shouldApplyAddingLabelFixit(tupleP, toTuple, fromTuple,
locInsertPairs)) {
It's not clear if this is a real bug that needs to be fixed, or merely an incorrect variable name.
The text was updated successfully, but these errors were encountered: