Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-7052] Clean up the compactMap overloads #49600

Open
moiseev mannequin opened this issue Feb 21, 2018 · 3 comments
Open

[SR-7052] Clean up the compactMap overloads #49600

moiseev mannequin opened this issue Feb 21, 2018 · 3 comments
Assignees
@moiseev
Labels
improvement standard library Area: Standard library umbrella

Comments

@moiseev
Copy link
Mannequin

moiseev mannequin commented Feb 21, 2018

Previous ID SR-7052
Radar rdar://problem/37764446
Original Reporter @moiseev
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Improvement
Assignee @moiseev
Priority Medium

md5: 72669eaea0fb8753b3a5459a0231bba1

Issue Description:

When `String` started to conform to `Collection`, `flatMap` had to be overloaded to provide backward compatibility for a few cases. See this PR: #9466

Now that `compactMap` has been introduced instead of the problematic variant of `flatMap`, it should be possible to remove those overloads, since there had been no `compactMap` usages that need to be supported.

See relevant discussion here: https://forums.swift.org/t/why-is-there-a-collection-flatmap-that-takes-a-closure-returning-string/10141
@moiseev
Copy link
Mannequin Author

moiseev mannequin commented Feb 21, 2018

#14769

@moiseev
Copy link
Mannequin Author

moiseev mannequin commented Feb 21, 2018

@swift-cicreate

@moiseev
Copy link
Mannequin Author

moiseev mannequin commented Feb 21, 2018

#14779 for swift-4.1-branch

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moiseev moiseev

Labels
improvement standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants