Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-7154] Foundation PR testing broken #49702

Closed
aschwaighofer opened this issue Mar 9, 2018 · 5 comments
Closed

[SR-7154] Foundation PR testing broken #49702

aschwaighofer opened this issue Mar 9, 2018 · 5 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@aschwaighofer
Copy link
Member

Previous ID SR-7154
Radar rdar://38302264
Original Reporter @aschwaighofer
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug
Assignee None
Priority Medium

md5: 18ff818060b4bdc0ec4b3972113e0b02

Issue Description:

See discussion in https://forums.swift.org/t/swift-corelibs-foundation-testing-is-broken/10718/5

It seems that the build-script option 'foundation' was changed to 'debug-foundation' and swiftpm now complains:

x86_64-unknown-linux/release/swift-test: error while loading shared libraries: libswiftSwiftOnoneSupport.so: cannot open shared object file: No such file or directory
@aschwaighofer
Copy link
Member Author

@swift-ci create

@aschwaighofer
Copy link
Member Author

This was an intentional change: https://forums.swift.org/t/swift-corelibs-foundation-testing-is-broken/10718/7

@aschwaighofer
Copy link
Member Author

To reproduce:

./utils/build-script -R -T --llbuild --swiftpm --xctest --debug-foundation --libdispatch -- --reconfigure --lit-args=-v

# the following works. the only change: foundation instead of debug-foundation:
./utils/build-script -R -T --llbuild --swiftpm --xctest --foundation --libdispatch -- --reconfigure --lit-args=-v)

@spevans
Copy link
Collaborator

spevans commented Mar 25, 2018

The problem is that when `--debug-foundation` is used, `libFoundation.so` relies on `libswiftSwiftOnone.so` which is in the main swift build lib directory. However `libFoundation.so` does not know the path to this directory when it is loaded via the swift-package-manager` test binaries.

The solution is for the swift-package-manager test scripts to add an `LD_LIBRARY_PATH` to the environment with the path to the swift build lib dir.

There are 2 PRs that both need to go together:
apple/swift-package-manager#1544
#15498

@ankitspd
Copy link
Member

ankitspd commented Apr 3, 2018

This was done in apple/swift-corelibs-foundation#1495

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spevans @ankitspd @aschwaighofer