Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7624] Fixits for 'Argument passed to call that takes no arguments' #50166

Closed
AnthonyLatsis opened this issue May 7, 2018 · 2 comments
Closed
Assignees
Labels
compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers improvement

Comments

@AnthonyLatsis
Copy link
Collaborator

Previous ID SR-7624
Radar None
Original Reporter @AnthonyLatsis
Type Improvement
Status Closed
Resolution Won't Do
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, DiagnosticsQoI, StarterBug
Assignee @AnthonyLatsis
Priority Medium

md5: 5a858c599bca091812d15cb9d908974a

Issue Description:

Add simple fixits that remove the sourceRange of the argExpr. Right now there are only fixits for cases like foo(())

struct Foo {
  subscript() -> Int { return 0}
}
_ = Foo()[8] // Argument passed to call that takes no arguments; suggest to fix to []

func foo() {}
foo(8) // same error; suggest to fix to foo()
foo("hello", 5) // same error; suggest to fix to foo()
@AnthonyLatsis
Copy link
Collaborator Author

PR for master – #16652

@AnthonyLatsis
Copy link
Collaborator Author

We have agreed this isn't a productive change.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation good first issue Good for newcomers improvement
Projects
None yet
Development

No branches or pull requests

1 participant