Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-7713] Adding redundant RandomAccessCollection conformance mysteriously causes code to be less optimized #50253

Closed
jckarter opened this issue May 17, 2018 · 4 comments
Closed

[SR-7713] Adding redundant RandomAccessCollection conformance mysteriously causes code to be less optimized #50253

jckarter opened this issue May 17, 2018 · 4 comments
Assignees
@eeckstein
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself performance

Comments

@jckarter
Copy link
Member

Previous ID SR-7713
Radar rdar://problem/40332203
Original Reporter @jckarter
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Bug, Performance
Assignee @eeckstein
Priority Medium

md5: 73c95352ada648a924d75e857116dd58

Issue Description:

The example in this post gets compiled to much slower code when the `BitVector` type is made to conform to `RandomAccessCollection`, even though the conformance is not directly used:

https://forums.swift.org/t/why-does-adding-conformance-to-randomaccesscollection-cause-a-performance-regression/12435/17
@jckarter
Copy link
Member Author

@swift-ci create

@swift-ci
Copy link
Collaborator

Comment by Seth Bromberger (JIRA)

Hi all - don't mean to be a nag, but I'm wondering whether there's a status update for this issue? Thanks.

@jckarter
Copy link
Member Author

I don't see any activity looking into this issue yet, but it is in the performance team's queue to be looked at soon. Sorry for the hold up.

@eeckstein
Copy link
Member

fixed in #19120

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeckstein eeckstein

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jckarter @eeckstein @swift-ci