Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-7780] [Perf] String Regressions in LuhnAlgo, Phonebook #50319

Open
milseman mannequin opened this issue May 25, 2018 · 1 comment
Open

[SR-7780] [Perf] String Regressions in LuhnAlgo, Phonebook #50319

milseman mannequin opened this issue May 25, 2018 · 1 comment
Assignees
@eeckstein
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@milseman
Copy link
Mannequin

milseman mannequin commented May 25, 2018

Previous ID SR-7780
Radar None
Original Reporter @milseman
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug
Assignee @eeckstein
Priority Medium

md5: e7032d31ca749bc1791b0d96d2762dc8

Issue Description:

#16733 made a lot of improvements, but a handful of benchmarks regressions. When I looked at the profiles for LuhnAlgo (with a slightly earlier revision), it seems like we were allocating more closures than before. Phonebook continues to be elusive due to it using the highly-recursive intro_sort.
@milseman
Copy link
Mannequin Author

milseman mannequin commented May 25, 2018

That PR is a good idea, filling this to help track those regressions.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeckstein eeckstein

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants