Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7824] swiftpm ignores missing source symlinks #4807

Closed
ankitspd opened this issue May 31, 2018 · 1 comment
Closed

[SR-7824] swiftpm ignores missing source symlinks #4807

ankitspd opened this issue May 31, 2018 · 1 comment
Labels

Comments

@ankitspd
Copy link
Member

Previous ID SR-7824
Radar rdar://problem/34346476
Original Reporter @aciidb0mb3r
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 357a04b6a7139fbe1037172faee145fe

is duplicated by:

  • SR-7826 SwiftPM should warn if it skips traversing a symlink which would contain sources in it

Issue Description:

/tmp❯ mkdir test
/tmp❯ cd test
/tmp/test❯ swift package init
Creating library package: test
Creating Package.swift
Creating README.md
Creating .gitignore
Creating Sources/
Creating Sources/test/test.swift
Creating Tests/
Creating Tests/LinuxMain.swift
Creating Tests/testTests/
Creating Tests/testTests/testTests.swift
/tmp/test❯ ln -sfh /tmp/missing.swift Sources/test/test2.swift
/tmp/test❯ ln -sfh /tmp/missing.swift Tests/testTests/testTests2.swift
/tmp/test❯ swift build
Compile Swift Module 'test' (1 sources)
/tmp/test❯ swift test
Compile Swift Module 'testTests' (1 sources)
Linking ./.build/x86_64-apple-macosx10.10/debug/testPackageTests.xctest/Contents/MacOS/testPackageTests
Test Suite 'All tests' started at 2017-09-08 20:46:06.805
Test Suite 'testPackageTests.xctest' started at 2017-09-08 20:46:06.805
Test Suite 'testTests' started at 2017-09-08 20:46:06.805
Test Case '-[testTests.testTests testExample]' started.
Test Case '-[testTests.testTests testExample]' passed (2.563 seconds).
Test Suite 'testTests' passed at 2017-09-08 20:46:09.368.
Executed 1 test, with 0 failures (0 unexpected) in 2.563 (2.563) seconds
Test Suite 'testPackageTests.xctest' passed at 2017-09-08 20:46:09.368.
Executed 1 test, with 0 failures (0 unexpected) in 2.563 (2.563) seconds
Test Suite 'All tests' passed at 2017-09-08 20:46:09.368.
Executed 1 test, with 0 failures (0 unexpected) in 2.563 (2.563) seconds

There should be at least a warning if one of the source files is a link to something that doesn't exist.

@ankitspd
Copy link
Member Author

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant