Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-7833] swift run should accept --build-tests #4798

Closed
ankitspd opened this issue May 31, 2018 · 5 comments
Closed

[SR-7833] swift run should accept --build-tests #4798

ankitspd opened this issue May 31, 2018 · 5 comments
Labels

Comments

@ankitspd
Copy link
Member

Previous ID SR-7833
Radar rdar://problem/36701396
Original Reporter @aciidb0mb3r
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: e3b0f0705606702ce56ce09891010c25

Issue Description:

`swift run` should accept --build-tests similar to `swift build`

@swift-ci
Copy link
Contributor

Comment by Guillermo Ignacio Enriquez Gutierrez (JIRA)

Hello @aciidb0mb3r
I am new in the swift pm repository. And since this issue had the StarterBug label I assigned it to me.

I have implemented --build-tests flag but I realized there is another flag: --skip-build. So I have a question about ideal spec.

What should happen when these two are given?

$ swift-run --skip-build --build-tests

I saw that swift build tool emits this:

$ swift-build --target myTarget --build-tests
error: '--target' and '--build-tests' are mutually exclusive

Do you want me to show emit something similar? or give more importance to --build-tests? or give more importance to --skip-build?

@swift-ci
Copy link
Contributor

swift-ci commented Jul 2, 2018

Comment by Guillermo Ignacio Enriquez Gutierrez (JIRA)

@aciidb0mb3r Hello Ankit, I wonder if you saw my question 🙂. Any update?

@ankitspd
Copy link
Member Author

ankitspd commented Jul 2, 2018

Ah, sorry I missed your comment earlier. I think it makes sense to print an error and say that these flags are mutually exclusive.

@swift-ci
Copy link
Contributor

swift-ci commented Jul 9, 2018

Comment by Guillermo Ignacio Enriquez Gutierrez (JIRA)

Here is the pull request. This is my first pull request to swift package manager so please bear with me :p

https://bugs.swift.org/browse/SR-7833

@ankitspd
Copy link
Member Author

ankitspd commented Jul 9, 2018

Resolved by #1654

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants